From 82c29a416d8ec6c74335468c5cb75291141a879d Mon Sep 17 00:00:00 2001 From: Jeff Lloyd Date: Mon, 24 Apr 2023 10:03:40 -0700 Subject: [PATCH 1/3] Add description field to Workflow constructor --- workflow-types/src/lib.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/workflow-types/src/lib.rs b/workflow-types/src/lib.rs index 319ca13..fc3f6eb 100644 --- a/workflow-types/src/lib.rs +++ b/workflow-types/src/lib.rs @@ -59,12 +59,16 @@ impl Workflow { &self.shells } - pub fn new(name: impl Into, command: impl Into) -> Self { + pub fn new( + name: impl Into, + command: impl Into, + description: Option, + ) -> Self { Workflow { name: name.into(), command: command.into(), tags: vec![], - description: None, + description, arguments: vec![], source_url: None, author: None, From e7eda67de78dd19ddad735ce0a317ef4a50969b3 Mon Sep 17 00:00:00 2001 From: Jeff Lloyd Date: Mon, 24 Apr 2023 11:12:14 -0700 Subject: [PATCH 2/3] Use builder pattern instead --- workflow-types/src/lib.rs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/workflow-types/src/lib.rs b/workflow-types/src/lib.rs index fc3f6eb..c17cfb6 100644 --- a/workflow-types/src/lib.rs +++ b/workflow-types/src/lib.rs @@ -59,16 +59,12 @@ impl Workflow { &self.shells } - pub fn new( - name: impl Into, - command: impl Into, - description: Option, - ) -> Self { + pub fn new(name: impl Into, command: impl Into) -> Self { Workflow { name: name.into(), command: command.into(), tags: vec![], - description, + description: None, arguments: vec![], source_url: None, author: None, @@ -81,6 +77,11 @@ impl Workflow { self.arguments = arguments; self } + + pub fn with_description(mut self, description: String) -> Self { + self.description = Some(description.clone()); + self + } } #[derive(Clone, Debug, Deserialize, Serialize, Eq, PartialEq, Hash, PartialOrd)] From c8ebff56e4a6021f939a6f21af4e528886565cac Mon Sep 17 00:00:00 2001 From: Jeff Lloyd Date: Mon, 24 Apr 2023 11:31:40 -0700 Subject: [PATCH 3/3] PR fix --- workflow-types/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workflow-types/src/lib.rs b/workflow-types/src/lib.rs index c17cfb6..57fd7f8 100644 --- a/workflow-types/src/lib.rs +++ b/workflow-types/src/lib.rs @@ -79,7 +79,7 @@ impl Workflow { } pub fn with_description(mut self, description: String) -> Self { - self.description = Some(description.clone()); + self.description = Some(description); self } }