Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License missing from gemspec #1

Closed
bf4 opened this issue Jul 11, 2013 · 4 comments

Comments

@bf4
Copy link

commented Jul 11, 2013

No description provided.

@ghost ghost assigned reggieb Jul 11, 2013

@reggieb

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2013

Hmmm ... The license is there in the s.files declaration. I've add a license declaration to the code, but this won't get into the gem until the next update (I don't think this change warrants a version update and subsequent new gem build).

I notice the rubygems specification reference has the license declaration as optional:

http://guides.rubygems.org/specification-reference/

@bf4 is there a specific reason why the lack of a license declaration is causing a problem for you? As if so, I should update all my gems!

@bf4

This comment has been minimized.

Copy link
Author

commented Jul 12, 2013

The license being optional in the gemspec only means that a valid gemspec does not require it. Some companies will only use gems with a certain license. The canonical and easy way to check is via the gemspec. e.g. see https://github.com/pivotal/LicenseFinder It's a good practice, in any case.

So, yes, it would be great to update all your gems.

I'm collecting stats on recently released gems, originally looking for download data, but decided to collect licenses too, and make issues for missing ones as a public service :) https://gist.github.com/bf4/5952053#file-license_issue-rb-L13 So far it's going pretty well

@reggieb

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2013

I found a couple of bugs today so have updated the gem, so the license declaration is now live in the gem.

I'll look to work through the rest of my gems and add the license declarations.

Thanks @bf4

@reggieb reggieb closed this Jul 12, 2013

@bf4

This comment has been minimized.

Copy link
Author

commented Jul 12, 2013

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.