Use FastBlur as a fallback upon RenderScript failure #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain low-end devices crash when calling RenderScript.create(context). A solution to this issue is beyond my control so, instead, I created a fallback solution. It now uses the FastBlur class when RenderScript fails. http://trickyandroid.com/advanced-blurring-techniques/ Cons: - Memory usage is higher than RenderScript on affected devices. Pros: - It no longer crashes on affected devices. - The process remains the exact same on devices which it previously worked fine on.
|
This should fix issue #16 |
|
Thank you. I will check. |
|
You can also use FastBlur to provide a "lite" version of this Blurry library without the renderscriptSupportModeEnabled requirement. I'm using a custom version of Blurry in my project that uses the FastBlur class on APIs below 17 (and non-support RS in 17+) and it has made my .apk size 2.5MB smaller! I can include that change too, if you'd like. :D |
wasabeef
added a commit
that referenced
this pull request
Feb 27, 2016
Use FastBlur as a fallback upon RenderScript failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain low-end devices crash when calling RenderScript.create(context).
A solution to this issue is beyond my control so, instead, I created a
fallback solution. It now uses the FastBlur class when RenderScript
fails.
http://trickyandroid.com/advanced-blurring-techniques/
Cons:
Pros:
worked fine on.