New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Simplify and document scripting to add `active`, `dogeared` to nav #328

Merged
merged 2 commits into from Jan 6, 2016

Conversation

Projects
None yet
1 participant
@jeremyfelt
Collaborator

jeremyfelt commented Jan 6, 2016

active and dogeared are both important for proper styling in the navigation. This clarifies some of the logic attached to applying these styles and drops a .active:not(:has(.active)) that was super confusing.

From what I can tell, everything appears to work as is and better in our test suite, which uses the active method and relies on the Spine to add dogeared.

jeremyfelt added some commits Jan 6, 2016

Simplify and document scripting to add `active`, `dogeared` to nav
`active` and `dogeared` are both important for proper styling in
the navigation. This clarifies some of the logic attached to applying
these styles and drops a `.active:not(:has(.active))` that was super
confusing.

From what I can tell, everything appears to work as is and better
in our test suite, which uses the `active` method and relies on
the Spine to add `dogeared`.

@jeremyfelt jeremyfelt added the bug label Jan 6, 2016

@jeremyfelt jeremyfelt self-assigned this Jan 6, 2016

@jeremyfelt jeremyfelt added this to the Next Release milestone Jan 6, 2016

jeremyfelt added a commit that referenced this pull request Jan 6, 2016

Merge pull request #328 from washingtonstateuniversity/active-dogeare…
…d-current-parents

[PR] Simplify and document scripting to add `active`, `dogeared` to nav

@jeremyfelt jeremyfelt merged commit 12cc965 into develop Jan 6, 2016

@jeremyfelt jeremyfelt deleted the active-dogeared-current-parents branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment