New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Additional work on mobile scrolling behavior #334

Merged
merged 9 commits into from Mar 16, 2016

Conversation

Projects
None yet
1 participant
@jeremyfelt
Collaborator

jeremyfelt commented Mar 16, 2016

On mobile page views, we need to position .spine-footer slightly below the edge of the window so that scrolling behavior acts as expected. We only need to handle this once, on the initial page view, as no menu collapsing happens after that. We can now remove the DOM change trigger for mobile views entirely.

jeremyfelt added some commits Mar 16, 2016

Add a margin to Spine footer when a short nav on a mobile view
If we don't do this, and the scrollable navigation area is smaller
than the window size on iOS, we get funky battles between scroll
areas, even though we've disabled the background scroll.
Only watch for DOM changes on non-mobile views
Now that we've removed the repeat processing attached to the mobile
view, we can unhook the logic watching for changes in the nav
Check for `#scroll` element when processing touch events
We already match any parents that are `#scroll`, but that may miss
an event fired on `#scroll` itself

@jeremyfelt jeremyfelt added the bug label Mar 16, 2016

@jeremyfelt jeremyfelt self-assigned this Mar 16, 2016

jeremyfelt added a commit that referenced this pull request Mar 16, 2016

Merge pull request #334 from washingtonstateuniversity/continued-scro…
…ll-work

[PR] Additional work on mobile scrolling behavior

@jeremyfelt jeremyfelt merged commit 07e0c60 into develop Mar 16, 2016

@jeremyfelt jeremyfelt deleted the continued-scroll-work branch Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment