New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child pages not in the navigation should cause their parent page to be active in navigation #228

Closed
jeremyfelt opened this Issue Jul 10, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@jeremyfelt
Collaborator

jeremyfelt commented Jul 10, 2015

No description provided.

@jeremyfelt jeremyfelt added the bug label Jul 10, 2015

@natejacobson

This comment has been minimized.

natejacobson commented Jul 10, 2015

This should also be combined with #85. I think the solution in cases like this ought to be the ability to manually choose the preferred active link.

@jeremyfelt

This comment has been minimized.

Collaborator

jeremyfelt commented Jul 10, 2015

Agreed with combination with #85, as it's very similar. However, if a parent->child relationship is defined, wouldn't it make sense to highlight the parent automatically if the child did not exist?

@natejacobson

This comment has been minimized.

natejacobson commented Jul 10, 2015

Yes. Probably. I'm just wondering if there are times when you wouldn't want that behavior. Maybe if the metabox in #85 also enabled the ability to choose none, then you'd have the best of both worlds. By default, the parent is highlighted, but you could prevent it from doing so. The use case I'm trying to preserve may be vanishingly small, though. (Autocomplete keeps changing metabox to meatball. Now a meatball hoagie sounds good.)

@jeremyfelt

This comment has been minimized.

Collaborator

jeremyfelt commented Jul 10, 2015

Well, the shortcode UI is shortcake (https://wordpress.org/plugins/shortcode-ui/)... maybe we need a Meatball UI.

I think that makes sense. Sane auto-behavior with an override.

@jeremyfelt jeremyfelt added this to the Next Release milestone Jan 22, 2016

@jeremyfelt jeremyfelt self-assigned this Jan 22, 2016

@jeremyfelt

This comment has been minimized.

Collaborator

jeremyfelt commented Jan 22, 2016

Noting that this came up in open labs today. It magically works in BU Navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment