Skip to content

Wasm interface types and multi-value #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fitzgen merged 2 commits into from
Oct 18, 2019
Merged

Wasm interface types and multi-value #1805

fitzgen merged 2 commits into from
Oct 18, 2019

Conversation

@fitzgen
Copy link
Contributor

@fitzgen fitzgen commented Oct 3, 2019

fitzgen added 2 commits October 3, 2019 12:57
@fitzgen
Wasm interface types should imply multi-value
311ae19
@fitzgen
Get rid of the wasm interface types return pointer hacks
25dd84c 
Now that using standard Wasm interface types implies multi-value support, we
don't need these return pointer hacks anymore.
@fitzgen fitzgen requested a review from alexcrichton October 3, 2019 20:38
alexcrichton
alexcrichton approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a satisfying review on this one!

@fitzgen fitzgen merged commit fe4dd0b into wasm-bindgen:master Oct 18, 2019
@fitzgen fitzgen deleted the wasm-interface-types-and-multi-value branch October 18, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexcrichton alexcrichton alexcrichton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fitzgen @alexcrichton