Skip to content

Conversation

@alexcrichton
Copy link
Contributor

When we're emitting a bindings section we need to be sure to update the
listed type of the binding in addition to the actual binding
expressions. This should help remove the stray return pointer being
listed there by accident!

When we're emitting a bindings section we need to be sure to update the
listed type of the binding in addition to the actual binding
expressions. This should help remove the stray return pointer being
listed there by accident!
@alexcrichton alexcrichton requested a review from fitzgen October 29, 2019 03:26
@alexcrichton alexcrichton merged commit 9b8711a into wasm-bindgen:master Oct 29, 2019
@alexcrichton alexcrichton deleted the remove-retptr branch October 29, 2019 13:55
Copy link
Contributor

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants