This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can see a lot of unimplemented!() in machine_arm64.rs. Generally unimplemented! means the same thing as todo!: "this code is not implemented yet but needs to be implemented".
Use unreachable! instead to indicate "I am sure that this code is unreachable". They both panic, but it makes it clearer whether there is still work to be done.
I have use unimplemented!() in place where an implementation should exist. At least for the Atomic movement. And I used unreachable!() in place were I didn't expected an implementation to be needed. But I may have letfs some unimplemented!()in wrong places, but I did had the same schema in mind.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.