Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialize FrameInfo on Dylib engine (for #1727) #2768

Merged
merged 4 commits into from Jan 27, 2022
Merged

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jan 27, 2022

Description

Add serialization of Frame Info (except when using llvm) for the Dylib engine, so Trap Information is still valid and the correct trap are triggered by the program.

@ptitSeb ptitSeb requested review from Amanieu and syrusakbary Jan 27, 2022
@Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Jan 27, 2022

We have some tests in ignore.txt that are disabled due to #1727, can you try re-enabling them?

@ptitSeb
Copy link
Contributor Author

@ptitSeb ptitSeb commented Jan 27, 2022

We have some tests in ignore.txt that are disabled due to #1727, can you try re-enabling them?

Ah yes. I have remove the tests from the ignore.txt, they are working.

@Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Jan 27, 2022

bors r+

Copy link
Member

@syrusakbary syrusakbary left a comment

Approving just in case (not sure if bors will work? I think it should, but I'm not sure!)

@bors
Copy link
Contributor

@bors bors bot commented Jan 27, 2022

@bors bors bot merged commit 9d5e4ff into master Jan 27, 2022
14 checks passed
@bors bors bot deleted the fix_dylib_frameinfo branch Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants