Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Singlepass f32_load and f64_load function, and introduce emit_bond_label_far as direct bcond may not work all the time (for #2777) #2778

Merged
merged 1 commit into from Feb 7, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Feb 1, 2022

Description

Aarch64 singlepass fix for #2777 :

  • Change implementation of f32_load and f64_load to be more flexible
  • Instroduce the emit_bcond_label_far emitter to alow use of bcond on "farther" reloc. It does slow down a little bit (like less than 5% on less powerfull devices), but it's cecessary to be able to run larger wasm file. Also, beeing "singlepass", no real smart way alay to detect if a "far" version is needed or not (so "far" are used everywhere).

…ond_label_far as direct bcond may not work all the time (for #2777)
@ptitSeb ptitSeb requested a review from syrusakbary as a code owner Feb 1, 2022
@ptitSeb ptitSeb changed the title Fix Sdinglepass f32_load and f64_load function, and introduce emit_bond_label_far as direct bcond may not work all the time (for #2777) Fix Singlepass f32_load and f64_load function, and introduce emit_bond_label_far as direct bcond may not work all the time (for #2777) Feb 1, 2022
@ptitSeb ptitSeb requested a review from Amanieu Feb 2, 2022
@Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Feb 7, 2022

I'm a bit concerned about the performance, but <5% seems acceptable for now.

bors r+

@bors
Copy link
Contributor

@bors bors bot commented Feb 7, 2022

@bors bors bot merged commit bbb0381 into master Feb 7, 2022
14 checks passed
@bors bors bot deleted the fix/aarch64_singlepass_ldr_and_bcond_far branch Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants