Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change host_state drop order for InstanceHandle #2812



Copy link

@yun-yeo yun-yeo commented Mar 3, 2022


This PR is following #2806
We still met prev.start > max assertion error even after we pathed #2806.
#2086 seem fixed drop order problem on Module, but not solved it when we use Instance.

I found some other place which can cause drop order problem when we use Instance.
After we patch this, I couldn't see more prev.start > max assertion.

This instance handle will be stay in

/// Hosts can store arbitrary per-instance information here.
host_state: Box<dyn Any>,
of Instance.


  • Add a short description of the change to the file

Copy link

I think this fix makes sense for me. @Amanieu could you review it as well?

@yun-yeo yun-yeo requested a review from syrusakbary March 4, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants