Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change host_state drop order for InstanceHandle #2812

Merged

Conversation

YunSuk-Yeo
Copy link
Contributor

@YunSuk-Yeo YunSuk-Yeo commented Mar 3, 2022

Description

This PR is following #2806
We still met prev.start > max assertion error even after we pathed #2806.
#2086 seem fixed drop order problem on Module, but not solved it when we use Instance.

I found some other place which can cause drop order problem when we use Instance.
After we patch this, I couldn't see more prev.start > max assertion.

This instance handle will be stay in

/// Hosts can store arbitrary per-instance information here.
host_state: Box<dyn Any>,
of Instance.

Review

  • Add a short description of the change to the CHANGELOG.md file

@YunSuk-Yeo YunSuk-Yeo requested a review from syrusakbary as a code owner Mar 3, 2022
@syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Mar 3, 2022

I think this fix makes sense for me. @Amanieu could you review it as well?

lib/api/src/sys/module.rs Outdated Show resolved Hide resolved
Amanieu
Amanieu approved these changes Mar 3, 2022
@YunSuk-Yeo YunSuk-Yeo requested a review from syrusakbary Mar 4, 2022
@syrusakbary syrusakbary merged commit b04a41d into wasmerio:master Mar 7, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants