Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preopened fd and fix/improve fs syscalls; fix wasi memory access #343

Merged
merged 11 commits into from Apr 19, 2019

Conversation

@MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Apr 11, 2019

resolves #356

src/bin/wasmer.rs Outdated Show resolved Hide resolved
Loading
@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review Apr 19, 2019
@MarkMcCaskey MarkMcCaskey changed the title add preopened fd and fix/improve fs syscalls (WIP) add preopened fd and fix/improve fs syscalls Apr 19, 2019
@MarkMcCaskey MarkMcCaskey changed the title add preopened fd and fix/improve fs syscalls add preopened fd and fix/improve fs syscalls; fix wasi memory access Apr 19, 2019
@MarkMcCaskey MarkMcCaskey requested a review from lachlansneff Apr 19, 2019
lib/wasi/src/state.rs Outdated Show resolved Hide resolved
Loading
lib/wasi/src/syscalls/mod.rs Outdated Show resolved Hide resolved
Loading
lib/wasi/src/syscalls/mod.rs Outdated Show resolved Hide resolved
Loading
lib/wasi/src/ptr.rs Show resolved Hide resolved
Loading
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Okay, looks fine

Loading

@MarkMcCaskey
Copy link
Contributor Author

@MarkMcCaskey MarkMcCaskey commented Apr 19, 2019

bors r+

Loading

bors bot added a commit that referenced this issue Apr 19, 2019
343: add preopened fd and fix/improve fs syscalls; fix wasi memory access r=MarkMcCaskey a=MarkMcCaskey

resolves #356 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

@bors bors bot commented Apr 19, 2019

Canceled

Loading

@syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Apr 19, 2019

bors r+

Loading

@bors
Copy link
Contributor

@bors bors bot commented Apr 19, 2019

Merge conflict

Loading

@MarkMcCaskey
Copy link
Contributor Author

@MarkMcCaskey MarkMcCaskey commented Apr 19, 2019

bors r+

Loading

bors bot added a commit that referenced this issue Apr 19, 2019
343: add preopened fd and fix/improve fs syscalls; fix wasi memory access r=MarkMcCaskey a=MarkMcCaskey

resolves #356 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

@bors bors bot commented Apr 19, 2019

Loading

@bors bors bot merged commit 5a575cd into master Apr 19, 2019
3 checks passed
Loading
@bors bors bot deleted the feature/preopen-fd-and-more branch Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants