Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preopened fd and fix/improve fs syscalls; fix wasi memory access #343

Merged
merged 11 commits into from Apr 19, 2019

Conversation

@MarkMcCaskey
Copy link
Contributor

commented Apr 11, 2019

resolves #356

@xmclark xmclark self-requested a review Apr 12, 2019

Show resolved Hide resolved src/bin/wasmer.rs Outdated

@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review Apr 19, 2019

@MarkMcCaskey MarkMcCaskey changed the title add preopened fd and fix/improve fs syscalls (WIP) add preopened fd and fix/improve fs syscalls Apr 19, 2019

@MarkMcCaskey MarkMcCaskey changed the title add preopened fd and fix/improve fs syscalls add preopened fd and fix/improve fs syscalls; fix wasi memory access Apr 19, 2019

@MarkMcCaskey MarkMcCaskey requested a review from lachlansneff Apr 19, 2019

Show resolved Hide resolved lib/wasi/src/state.rs Outdated
Show resolved Hide resolved lib/wasi/src/syscalls/mod.rs Outdated
Show resolved Hide resolved lib/wasi/src/syscalls/mod.rs Outdated
Show resolved Hide resolved lib/wasi/src/ptr.rs
@lachlansneff
Copy link
Contributor

left a comment

Okay, looks fine

@MarkMcCaskey

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 19, 2019

Merge #343
343: add preopened fd and fix/improve fs syscalls; fix wasi memory access r=MarkMcCaskey a=MarkMcCaskey

resolves #356 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Canceled

@syrusakbary

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Merge conflict

@MarkMcCaskey

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 19, 2019

Merge #343
343: add preopened fd and fix/improve fs syscalls; fix wasi memory access r=MarkMcCaskey a=MarkMcCaskey

resolves #356 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors

This comment has been minimized.

@bors bors bot merged commit 5a575cd into master Apr 19, 2019

3 checks passed

bors Build succeeded
Details
ci/circleci: changelog Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details

@bors bors bot deleted the feature/preopen-fd-and-more branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.