Introduce ModuleError enum for errors #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelang
reviewed
Dec 17, 2018
|
|
||
| impl ModuleValidator for CheckStartFunc { | ||
| fn validate(&self, module: &Module) -> Result<bool, String> { | ||
| fn validate(&self, module: &Module) -> Result<bool, ModuleError> { |
Collaborator
There was a problem hiding this comment.
Alternative idea: Replace the current Result<bool, ModuleError> with a simpler ModuleResult which can have the variants Valid, Invalid, Mutated, Unsupported, Other(String)
Member
Author
There was a problem hiding this comment.
One downside is that I think unwrap cannot be used in that case.
Collaborator
There was a problem hiding this comment.
Oh yeah, true. I just realized that the methods are implemented directly rather than via a trait. this is good for merge then?
jakelang
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #50.