Skip to content

Conversation

@s1na
Copy link
Collaborator

@s1na s1na commented May 31, 2019

This was the wat generated for the memory deployer:

(module
   (type (;0;) (func (param i32 i32)))
   (type (;1;) (func))
   (import "ethereum" "finish" (func (;0;) (type 0)))
   (func (;1;) (type 0) (param i32 i32))
   (func (;2;) (type 1)
     i32.const 0
     i32.const 519686
     call 0)
   (memory (;0;) 8)
   (export "main" (func 1))
   (export "memory" (memory 0))
...

However (func 1) has the signature for ethereum::finish, which resulted in invalid signature for main. (the (func 1) seems redundant to me anyway)

@axic
Copy link
Member

axic commented Jun 2, 2019

Rebased.

@axic axic force-pushed the fix/mem-deployer branch from 8840321 to 08a9e47 Compare June 2, 2019 19:56
@axic
Copy link
Member

axic commented Jun 2, 2019

Great find!

@axic axic merged commit 1539b3b into wasmx:master Jun 2, 2019
@s1na s1na deleted the fix/mem-deployer branch June 3, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants