Wait for all processes in the process group #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passcod
approved these changes
Nov 19, 2022
|
Thank you! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 19, 2022
7: Wait for all processes in the process group r=passcod a=malyn This avoids zombie processes that would otherwise be created if the child process exits after spawning its own children, but without waiting for those children to exit. This change ensures that `wait` reaps all of those zombie processes, while still returning the exit code from the original process that was spawned (Command Group's direct child). One note: I wasn't entirely sure if this should be in Command Group or in my application code, but the documentation of the [`AsyncGroupChild::wait`](https://docs.rs/command-group/1.0.8/command_group/struct.AsyncGroupChild.html#method.wait) function suggested that cleaning up all of the children in the process *group* might have been what was intended: > Waits for the child group to exit completely, returning the status that the process leader exited with. The Tokio code does not perform this reaping though, and I realize that Command Group is ultimately based on the Tokio API, so, as I said, not entirely sure if this is the right place for this logic. Co-authored-by: Michael Alyn Miller <malyn@strangeGizmo.com>
|
Build failed: |
This avoids zombie processes that would otherwise be created if the child process exits after spawning its own children, but without waiting for those children to exit. This change ensures that `wait` reaps all of those zombie processes, while still returning the exit code from the original process that was spawned (Command Group's direct child).
passcod
force-pushed
the
wait-all-children
branch
from
13cb9e0
to
e815fa8
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids zombie processes that would otherwise be created if the child process exits after spawning its own children, but without waiting for those children to exit. This change ensures that
waitreaps all of those zombie processes, while still returning the exit code from the original process that was spawned (Command Group's direct child).One note: I wasn't entirely sure if this should be in Command Group or in my application code, but the documentation of the
AsyncGroupChild::waitfunction suggested that cleaning up all of the children in the process group might have been what was intended:The Tokio code does not perform this reaping though, and I realize that Command Group is ultimately based on the Tokio API, so, as I said, not entirely sure if this is the right place for this logic.