Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Allow the default wait timeout to be configurable #66
Allows configuration of the default wait timeout used by the wait methods - wait_until, wait_while, when_present, wait_while_present and wait_until_present:
Watir.default_timeout = 60
This is similar to a recent change in Watir-Webdriver (watir/watir-webdriver#230). As well, this changes the default timeout to be 30 seconds for consistency.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I agree that moving the specs to watirspec would be better. What would the process be for that?
For the wait_spec, should I just move the tests that describe "Watir.default_timeout"? There seem to be other wait related specs in watir-webdriver that I would think apply to watir-classic as well - for example #wait_until_present. Should I move those as well or perhaps leave that for a different pull request?
So far I think you can move the whole wait spec to watirspec and bump it watir-webdriver. Then close this PR and open new one with full wait implementation and watirspec update.
At least that's what I would have done ;)