Allow the default wait timeout to be configurable #66

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
@jkotests
Owner

jkotests commented Nov 28, 2013

Allows configuration of the default wait timeout used by the wait methods - wait_until, wait_while, when_present, wait_while_present and wait_until_present:

Watir.default_timeout = 60

This is similar to a recent change in Watir-Webdriver (watir/watir-webdriver#230). As well, this changes the default timeout to be 30 seconds for consistency.

@p0deje

This comment has been minimized.

Show comment Hide comment
@p0deje

p0deje Nov 29, 2013

Owner

I think it then makes sense to move specs to https://github.com/watir/watirspec

Owner

p0deje commented Nov 29, 2013

I think it then makes sense to move specs to https://github.com/watir/watirspec

@jkotests

This comment has been minimized.

Show comment Hide comment
@jkotests

jkotests Nov 29, 2013

Owner

I agree that moving the specs to watirspec would be better. What would the process be for that?

Would I:

  1. Create a pull request to watirspec to add the wait_spec and
  2. Create a pull request to watir-webdriver to remove the duplicated specs and
  3. Update this pull request to remove the duplicated specs

For the wait_spec, should I just move the tests that describe "Watir.default_timeout"? There seem to be other wait related specs in watir-webdriver that I would think apply to watir-classic as well - for example #wait_until_present. Should I move those as well or perhaps leave that for a different pull request?

Owner

jkotests commented Nov 29, 2013

I agree that moving the specs to watirspec would be better. What would the process be for that?

Would I:

  1. Create a pull request to watirspec to add the wait_spec and
  2. Create a pull request to watir-webdriver to remove the duplicated specs and
  3. Update this pull request to remove the duplicated specs

For the wait_spec, should I just move the tests that describe "Watir.default_timeout"? There seem to be other wait related specs in watir-webdriver that I would think apply to watir-classic as well - for example #wait_until_present. Should I move those as well or perhaps leave that for a different pull request?

@p0deje

This comment has been minimized.

Show comment Hide comment
@p0deje

p0deje Nov 29, 2013

Owner

So far I think you can move the whole wait spec to watirspec and bump it watir-webdriver. Then close this PR and open new one with full wait implementation and watirspec update.

At least that's what I would have done ;)

Cheers,
Alex

On 30 íîÿá. 2013 ã., at 0:25, Justin Ko notifications@github.com wrote:

I agree that moving the specs to watirspec would be better. What would the process be for that?

Would I:

Create a pull request to watirspec to add the wait_spec and
Create a pull request to watir-webdriver to remove the duplicated specs and
Update this pull request to remove the duplicated specs
For the wait_spec, should I just move the tests that describe "Watir.default_timeout"? There seem to be other wait related specs in watir-webdriver that I would think apply to watir-classic as well - for example #wait_until_present. Should I move those as well or perhaps leave that for a different pull request?


Reply to this email directly or view it on GitHub.

Owner

p0deje commented Nov 29, 2013

So far I think you can move the whole wait spec to watirspec and bump it watir-webdriver. Then close this PR and open new one with full wait implementation and watirspec update.

At least that's what I would have done ;)

Cheers,
Alex

On 30 íîÿá. 2013 ã., at 0:25, Justin Ko notifications@github.com wrote:

I agree that moving the specs to watirspec would be better. What would the process be for that?

Would I:

Create a pull request to watirspec to add the wait_spec and
Create a pull request to watir-webdriver to remove the duplicated specs and
Update this pull request to remove the duplicated specs
For the wait_spec, should I just move the tests that describe "Watir.default_timeout"? There seem to be other wait related specs in watir-webdriver that I would think apply to watir-classic as well - for example #wait_until_present. Should I move those as well or perhaps leave that for a different pull request?


Reply to this email directly or view it on GitHub.

Justin Ko and others added some commits Dec 1, 2013

Justin Ko
Move wait_spec to watirspec
The wait_spec is being moved to watirspec - see watir/watirspec#40
Justin Ko
Improved timeout message and add WhenPresentDecorator#present? and #r…
…espond_to?

For compliance with the watirspec/waitspec, the following changes were
made:

1. The element wait methods now include the element specifier in the
timeout message.
2. The WhenPresentDecorator now has #present? and #respond_to?
@jarmo

This comment has been minimized.

Show comment Hide comment
@jarmo

jarmo Oct 5, 2017

Owner

Closing this due to inactivity.

Owner

jarmo commented Oct 5, 2017

Closing this due to inactivity.

@jarmo jarmo closed this Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment