implement keyword support #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2017
p0deje
approved these changes
Jan 9, 2017
| @@ -49,10 +51,13 @@ def exists? | |||
| alias_method :exist?, :exists? | |||
|
|
|||
| def inspect | |||
| string = "#{self.class}: " | |||
There was a problem hiding this comment.
Let's keep it look like a usual Ruby inspect which wraps class in #<Class>:
string = "#<#{self.class}: "
# ...
string << '>'| it "displays selector string for regular element" do | ||
| browser.goto(WatirSpec.url_for("wait.html")) | ||
| describe "#inspect" do | ||
| before(:each) { browser.goto(WatirSpec.url_for("nested_iframes.html")) } |
titusfortner
force-pushed
the
keyword
branch
2 times, most recently
from
90fde24
to
57ddacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to set a keyword value for an element is especially useful for page object implementations. Rather than trying to match the selector output to a defined method, the user can now just look up the name of the element assigned. It would need to be implemented in the Page Object gems, but this provides the necessary hook for that.
Also, I changed the error messages to use
#selector_stringwhen really they should be using#inspectlike was there before.#selector_stringis still recursive, but#inspectincludes information about "located", "class name" and the new "keyword." (I removed the memory information; that is still available withElement#to_sif anyone cares about it).