From c464f18caae00c8f9393e6c919b0669ec7f0d17b Mon Sep 17 00:00:00 2001 From: Garrett May Date: Wed, 27 Jan 2016 11:20:54 -0500 Subject: [PATCH 01/29] fix typo in IDHelper (accoundId --> accountId) --- .../concept_insights/v2/util/IDHelper.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/util/IDHelper.java b/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/util/IDHelper.java index 784aa4bcbf2..989839a9963 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/util/IDHelper.java +++ b/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/util/IDHelper.java @@ -72,10 +72,10 @@ public static String getConceptId(final Concept concept) { * generated it. * * @param corpus Corpus the corpus object, - * @param accoundId String the account id. + * @param accountId String the account id. * @return the corpus id */ - public static String getCorpusId(final Corpus corpus, final String accoundId) { + public static String getCorpusId(final Corpus corpus, final String accountId) { Validate.notNull(corpus, "corpus cannot be null"); if (corpus.getId() != null) { validate(CORPUS_ID_REGEX, corpus.getId(), "Provide a valid corpus.id (format is " + '"' @@ -83,7 +83,7 @@ public static String getCorpusId(final Corpus corpus, final String accoundId) { return corpus.getId(); } else { Validate.notNull(corpus.getName(), "corpus.name cannot be null"); - return "/corpora/" + accoundId + "/" + corpus.getName(); + return "/corpora/" + accountId + "/" + corpus.getName(); } } @@ -107,10 +107,10 @@ public static String getDocumentId(final Document document) { * generated it. * * @param graph Graph the graph object, - * @param accoundId String the account id. + * @param accountId String the account id. * @return the graph id */ - public static String getGraphId(final Graph graph, final String accoundId) { + public static String getGraphId(final Graph graph, final String accountId) { Validate.notNull(graph, "graph object cannot be null"); if (graph.getId() != null) { validate(GRAPH_ID_REGEX, graph.getId(), "Provide a valid graph.id (format is " + '"' @@ -118,7 +118,7 @@ public static String getGraphId(final Graph graph, final String accoundId) { return graph.getId(); } else { Validate.notNull(graph.getName(), "graph.name cannot be null"); - return "/graphs/" + accoundId + "/" + graph.getName(); + return "/graphs/" + accountId + "/" + graph.getName(); } } From d237d926ee0c70d506fc6a494ff5278350e8d337 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 2 Feb 2016 08:40:44 -0500 Subject: [PATCH 02/29] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 603f8b8d6d4..debb1045013 100644 --- a/README.md +++ b/README.md @@ -459,7 +459,7 @@ System.out.println(recognizedImage); ``` ## Android -he library supports Android 2.3 and above. For Java, the minimum requirement is 1.7. +The library supports Android 2.3 and above. For Java, the minimum requirement is 1.7. It depends on [OkHttp][] and [gson][]. From 0dc3bbce8f0f861b2070c63b0e1ccfec2c7b6129 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 22:36:40 -0500 Subject: [PATCH 03/29] Updated websocket dependency --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 12ae8defbba..24923451694 100644 --- a/pom.xml +++ b/pom.xml @@ -41,7 +41,7 @@ com.neovisionaries nv-websocket-client - 1.19 + 1.21 From 1893993a387319847fd9f76ba2401c4d3fdf83a4 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 22:37:22 -0500 Subject: [PATCH 04/29] Get the http string from the http InputStream --- .../service/WatsonService.java | 2 +- .../developer_cloud/util/ResponseUtil.java | 29 +++++++------------ 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java b/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java index 2a66a497915..2f31c03d8de 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java +++ b/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java @@ -248,7 +248,7 @@ public String getToken() { * @return the error message from the JSON object */ private String getErrorMessage(Response response) { - String error = ResponseUtil.getResponseString(response); + String error = ResponseUtil.getString(response); try { final JsonObject jsonObject = ResponseUtil.getJsonObject(error); diff --git a/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java b/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java index 39dfab787ab..36298bec68b 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java +++ b/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java @@ -21,6 +21,7 @@ import com.google.gson.JsonElement; import com.google.gson.JsonObject; import com.google.gson.JsonParser; +import com.google.gson.stream.JsonReader; import com.ibm.watson.developer_cloud.service.model.GenericModel; import com.squareup.okhttp.Response; @@ -52,21 +53,6 @@ public static InputStream getInputStream(Response response) { } } - /** - * Returns the HTTP Response as a {@link String}. - * - * @param response an HTTP response - * @return the content body as String - */ - public static String getResponseString(Response response) { - try { - return response.body().string(); - } catch (final IOException e) { - log.log(Level.SEVERE, ERROR_MESSAGE, e); - throw new RuntimeException(ERROR_MESSAGE, e); - } - } - /** * Return a {@link JsonElement} representation of the response. * @@ -111,11 +97,18 @@ public static JsonObject getJsonObject(String jsonString) { * @return the POJO */ public static T getObject(Response response, Class type) { - final String jsonString = getString(response); - final T model = GsonSingleton.getGson().fromJson(jsonString, type); - return model; + JsonReader reader; + try { + reader = new JsonReader(response.body().charStream()); + final T model = GsonSingleton.getGson().fromJson(reader, type); + return model; + } catch (IOException e) { + log.log(Level.SEVERE, ERROR_MESSAGE, e); + throw new RuntimeException(ERROR_MESSAGE, e); + } } + /** * Returns a String representation of the response. * From 6e84e5aaad3c295ee33d5b39ebba0fbd4384daf3 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 22:39:59 -0500 Subject: [PATCH 05/29] Fixed #171 wrong query parameter --- .../language_translation/v2/LanguageTranslation.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java index 0e82533d077..fb6712f5568 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java +++ b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java @@ -68,8 +68,8 @@ public class LanguageTranslation extends WatsonService { /** The Constant NAME (value is "name"). */ private static final String NAME = "name"; - /** The Constant PARALLEL_CORPUS (value is "prallel_corpus"). */ - private static final String PARALLEL_CORPUS = "prallel_corpus"; + /** The Constant PARALLEL_CORPUS (value is "parallel_corpus"). */ + private static final String PARALLEL_CORPUS = "parallel_corpus"; /** The Constant SOURCE (value is "source"). */ private static final String SOURCE = "source"; From 05b1f69c78ec7ce2a8ec12e19e8b09f52764bc65 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 22:48:23 -0500 Subject: [PATCH 06/29] [concept-insights] Add expires_on and ttl_hours fields to the corpus object #168 --- .../concept_insights/v2/model/Corpus.java | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/model/Corpus.java b/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/model/Corpus.java index 1cf0e095516..bda9baf32fc 100755 --- a/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/model/Corpus.java +++ b/src/main/java/com/ibm/watson/developer_cloud/concept_insights/v2/model/Corpus.java @@ -48,6 +48,56 @@ public class Corpus extends GenericModel { /** The corpus name. */ private String name; + @SerializedName("ttl_hours") + private Integer ttlInHours; + // ttl_hours (integer, optional): Specify the TTL for the corpus in hours. This will internally + // set the expiration time after which the corpus will be automatically deleted. , + // expires_on (string, optional): Date and time in standard ISO format at which the corpus will + // expire and be marked for deletion. + + @SerializedName("expires_on") + private String expiresOn; + + /** + * Gets the time to live in hours. + * + * @return the time to live in hours + */ + public Integer getTtlInHours() { + return ttlInHours; + } + + /** + * Sets the time to live in hours. This will internally set the expiration time after which the + * corpus will be automatically deleted. + * + * @param ttlInHours the new time to live in hours + */ + public void setTtlInHours(Integer ttlInHours) { + this.ttlInHours = ttlInHours; + } + + /** + * Gets the expires on. + * + * @return the expires on + */ + public String getExpiresOn() { + return expiresOn; + } + + /** + * Sets the expires on. The value needs to be in standard ISO format at which the corpus will + * expire and be marked for deletion. + * + * For example: YYYY-MM-DD (e.g. 2016-07-16) + * + * @param expiresOn the new expires on + */ + public void setExpiresOn(String expiresOn) { + this.expiresOn = expiresOn; + } + /** * Instantiates a new corpus. */ From 94171770d14014e07fe6f24a12d0c7a45256f111 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 22:57:20 -0500 Subject: [PATCH 07/29] Added X-Watson-Learning-Opt-Out to prevent payload from being use to improve Watson. Specially since this are integration tests --- .../com/ibm/watson/developer_cloud/http/HttpHeaders.java | 4 ++++ .../com/ibm/watson/developer_cloud/WatsonServiceTest.java | 8 ++++++++ .../developer_cloud/alchemy/v1/AlchemyDataNewsIT.java | 2 +- .../developer_cloud/alchemy/v1/AlchemyLanguageIT.java | 1 + .../developer_cloud/alchemy/v1/AlchemyVisionIT.java | 1 + .../concept_expansion/v1/ConceptExpansionIT.java | 1 + .../concept_insights/v2/ConceptInsightsIT.java | 1 + .../watson/developer_cloud/dialog/v1/DialogServiceIT.java | 2 +- .../document_conversion/v1/DocumentConversionIT.java | 2 +- .../language_translation/v2/LanguageTranslationIT.java | 1 + .../v1/NaturalLanguageClassifierIT.java | 1 + .../personality_insights/v2/PersonalityInsightsIT.java | 1 + .../v1/RelationshipExtractionIT.java | 1 + .../retrieve_and_rank/v1/RetrieveAndRankIT.java | 1 + .../developer_cloud/speech_to_text/v1/SpeechToTextIT.java | 1 + .../developer_cloud/text_to_speech/v1/TextToSpeechIT.java | 1 + .../developer_cloud/tone_analyzer/v1/ToneAnalyzerIT.java | 1 + .../tradeoff_analytics/v1/TradeoffAnalyticsIT.java | 2 +- .../visual_insights/v1/VisualInsightsIT.java | 1 + .../visual_recognition/v2/VisualRecognitionIT.java | 1 + 20 files changed, 30 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/http/HttpHeaders.java b/src/main/java/com/ibm/watson/developer_cloud/http/HttpHeaders.java index 63db918e4e2..6ce0e7c0bde 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/http/HttpHeaders.java +++ b/src/main/java/com/ibm/watson/developer_cloud/http/HttpHeaders.java @@ -181,4 +181,8 @@ public interface HttpHeaders { /** The Authorization token header. */ public static final String X_WATSON_AUTHORIZATION_TOKEN = "X-Watson-Authorization-Token"; + + /** Allow Watson to collect the payload. */ + public static final String X_WATSON_LEARNING_OPT_OUT = "X-Watson-Learning-Opt-Out"; + } diff --git a/src/test/java/com/ibm/watson/developer_cloud/WatsonServiceTest.java b/src/test/java/com/ibm/watson/developer_cloud/WatsonServiceTest.java index 99d04f05122..7d20687dee4 100755 --- a/src/test/java/com/ibm/watson/developer_cloud/WatsonServiceTest.java +++ b/src/test/java/com/ibm/watson/developer_cloud/WatsonServiceTest.java @@ -24,12 +24,15 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.io.OutputStream; +import java.util.HashMap; +import java.util.Map; import java.util.Properties; import java.util.logging.Level; import java.util.logging.Logger; import org.slf4j.LoggerFactory; +import com.ibm.watson.developer_cloud.http.HttpHeaders; import com.ibm.watson.developer_cloud.util.GsonSingleton; /** @@ -49,6 +52,11 @@ public WatsonServiceTest() { setupLogging(); } + protected Map getDefaultHeaders() { + Map headers = new HashMap(); + headers.put(HttpHeaders.X_WATSON_LEARNING_OPT_OUT, String.valueOf(true)); + return headers; + } /** * The Class EmptyPropertyException. */ diff --git a/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyDataNewsIT.java b/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyDataNewsIT.java index ec8e8444807..c6c47893794 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyDataNewsIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyDataNewsIT.java @@ -43,7 +43,7 @@ public void setUp() throws Exception { super.setUp(); service = new AlchemyDataNews(); service.setApiKey(getValidProperty("alchemy.alchemy")); - + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyLanguageIT.java b/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyLanguageIT.java index 8ddbbac3537..2415fc27fd8 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyLanguageIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyLanguageIT.java @@ -60,6 +60,7 @@ public void setUp() throws Exception { super.setUp(); service = new AlchemyLanguage(); service.setApiKey(getValidProperty("alchemy.alchemy")); + service.setDefaultHeaders(getDefaultHeaders()); htmlExample = getStringFromInputStream(new FileInputStream("src/test/resources/alchemy/example.html")); diff --git a/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyVisionIT.java b/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyVisionIT.java index 529619b475e..d3d5b1ab73c 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyVisionIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/alchemy/v1/AlchemyVisionIT.java @@ -52,6 +52,7 @@ public void setUp() throws Exception { super.setUp(); service = new AlchemyVision(); service.setApiKey(getValidProperty("alchemy.alchemy")); + service.setDefaultHeaders(getDefaultHeaders()); htmlExample = getStringFromInputStream(new FileInputStream("src/test/resources/alchemy/example.html")); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/concept_expansion/v1/ConceptExpansionIT.java b/src/test/java/com/ibm/watson/developer_cloud/concept_expansion/v1/ConceptExpansionIT.java index d0025c174a6..b0f43b9c691 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/concept_expansion/v1/ConceptExpansionIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/concept_expansion/v1/ConceptExpansionIT.java @@ -42,6 +42,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("concept_expansion.username"), getValidProperty("concept_expansion.password")); service.setEndPoint(getValidProperty("concept_expansion.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/concept_insights/v2/ConceptInsightsIT.java b/src/test/java/com/ibm/watson/developer_cloud/concept_insights/v2/ConceptInsightsIT.java index 7a64e579fe6..6b5df3e53ad 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/concept_insights/v2/ConceptInsightsIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/concept_insights/v2/ConceptInsightsIT.java @@ -76,6 +76,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("concept_insights.username"), getValidProperty("concept_insights.password")); service.setEndPoint(getValidProperty("concept_insights.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/dialog/v1/DialogServiceIT.java b/src/test/java/com/ibm/watson/developer_cloud/dialog/v1/DialogServiceIT.java index 0cdf76e6a10..4c47f8d5503 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/dialog/v1/DialogServiceIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/dialog/v1/DialogServiceIT.java @@ -59,7 +59,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("dialog.username"), getValidProperty("dialog.password")); service.setEndPoint(getValidProperty("dialog.url")); - + service.setDefaultHeaders(getDefaultHeaders()); dialogId = getValidProperty("dialog.dialog_id"); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/document_conversion/v1/DocumentConversionIT.java b/src/test/java/com/ibm/watson/developer_cloud/document_conversion/v1/DocumentConversionIT.java index 0a05cfcb1cf..aa4c5af9036 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/document_conversion/v1/DocumentConversionIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/document_conversion/v1/DocumentConversionIT.java @@ -44,7 +44,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(prop.getProperty("document_conversion.username"), prop.getProperty("document_conversion.password")); service.setEndPoint(prop.getProperty("document_conversion.url")); - + service.setDefaultHeaders(getDefaultHeaders()); files = new File[] { new File("src/test/resources/document_conversion/word-docx-heading-input.docx"), diff --git a/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java b/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java index 7c70218fe4b..da5c18d17e4 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java @@ -58,6 +58,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("language_translation.username"), getValidProperty("language_translation.password")); service.setEndPoint(getValidProperty("language_translation.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/natural_language_classifier/v1/NaturalLanguageClassifierIT.java b/src/test/java/com/ibm/watson/developer_cloud/natural_language_classifier/v1/NaturalLanguageClassifierIT.java index ca1a6c31d1b..62939ce108a 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/natural_language_classifier/v1/NaturalLanguageClassifierIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/natural_language_classifier/v1/NaturalLanguageClassifierIT.java @@ -91,6 +91,7 @@ public void testClassify() throws Exception { public void setUp() throws Exception { super.setUp(); service = new NaturalLanguageClassifier(); + service.setDefaultHeaders(getDefaultHeaders()); service.setUsernameAndPassword(getValidProperty("natural_language_classifier.username"), getValidProperty("natural_language_classifier.password")); service.setEndPoint(getValidProperty("natural_language_classifier.url")); diff --git a/src/test/java/com/ibm/watson/developer_cloud/personality_insights/v2/PersonalityInsightsIT.java b/src/test/java/com/ibm/watson/developer_cloud/personality_insights/v2/PersonalityInsightsIT.java index 8a61a81f6e5..2f9487b8fb5 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/personality_insights/v2/PersonalityInsightsIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/personality_insights/v2/PersonalityInsightsIT.java @@ -48,6 +48,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("personality_insights.username"), getValidProperty("personality_insights.password")); service.setEndPoint(getValidProperty("personality_insights.url")); + service.setDefaultHeaders(getDefaultHeaders()); } @Test diff --git a/src/test/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtractionIT.java b/src/test/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtractionIT.java index c269f9f8cdf..ef0f9f12d3a 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtractionIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtractionIT.java @@ -45,6 +45,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("relationship_extraction.username"), getValidProperty("relationship_extraction.password")); service.setEndPoint(getValidProperty("relationship_extraction.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/retrieve_and_rank/v1/RetrieveAndRankIT.java b/src/test/java/com/ibm/watson/developer_cloud/retrieve_and_rank/v1/RetrieveAndRankIT.java index 939765a08b3..9e1efc9e140 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/retrieve_and_rank/v1/RetrieveAndRankIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/retrieve_and_rank/v1/RetrieveAndRankIT.java @@ -63,6 +63,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("retrieve_and_rank.username"), getValidProperty("retrieve_and_rank.password")); service.setEndPoint(getValidProperty("retrieve_and_rank.url")); + service.setDefaultHeaders(getDefaultHeaders()); rankerId = getValidProperty("retrieve_and_rank.ranker_id"); clusterId = getValidProperty("retrieve_and_rank.cluster_id"); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java b/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java index 3fbae1f5c25..beb92da0120 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java @@ -59,6 +59,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("speech_to_text.username"), getValidProperty("speech_to_text.password")); service.setEndPoint(getValidProperty("speech_to_text.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/text_to_speech/v1/TextToSpeechIT.java b/src/test/java/com/ibm/watson/developer_cloud/text_to_speech/v1/TextToSpeechIT.java index 7b2861ecbb2..4ea176106b6 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/text_to_speech/v1/TextToSpeechIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/text_to_speech/v1/TextToSpeechIT.java @@ -64,6 +64,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(prop.getProperty("text_to_speech.username"), prop.getProperty("text_to_speech.password")); service.setEndPoint(prop.getProperty("text_to_speech.url")); + service.setDefaultHeaders(getDefaultHeaders()); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/tone_analyzer/v1/ToneAnalyzerIT.java b/src/test/java/com/ibm/watson/developer_cloud/tone_analyzer/v1/ToneAnalyzerIT.java index 3d204a91ba0..35792d7ae2d 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/tone_analyzer/v1/ToneAnalyzerIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/tone_analyzer/v1/ToneAnalyzerIT.java @@ -46,6 +46,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("tone_analyzer.username"), getValidProperty("tone_analyzer.password")); service.setEndPoint(getValidProperty("tone_analyzer.url")); + service.setDefaultHeaders(getDefaultHeaders()); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/tradeoff_analytics/v1/TradeoffAnalyticsIT.java b/src/test/java/com/ibm/watson/developer_cloud/tradeoff_analytics/v1/TradeoffAnalyticsIT.java index 30280e91892..f9695f67d01 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/tradeoff_analytics/v1/TradeoffAnalyticsIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/tradeoff_analytics/v1/TradeoffAnalyticsIT.java @@ -54,7 +54,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("tradeoff_analytics.username"), getValidProperty("tradeoff_analytics.password")); service.setEndPoint(getValidProperty("tradeoff_analytics.url")); - + service.setDefaultHeaders(getDefaultHeaders()); problem = loadFixture("src/test/resources/tradeoff_analytics/problem.json", Problem.class); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/visual_insights/v1/VisualInsightsIT.java b/src/test/java/com/ibm/watson/developer_cloud/visual_insights/v1/VisualInsightsIT.java index 81a1be7a540..fd8e257c783 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/visual_insights/v1/VisualInsightsIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/visual_insights/v1/VisualInsightsIT.java @@ -52,6 +52,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("visual_insights.username"), getValidProperty("visual_insights.password")); service.setEndPoint(getValidProperty("visual_insights.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** diff --git a/src/test/java/com/ibm/watson/developer_cloud/visual_recognition/v2/VisualRecognitionIT.java b/src/test/java/com/ibm/watson/developer_cloud/visual_recognition/v2/VisualRecognitionIT.java index ba18a90bb40..b1ebc0e971f 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/visual_recognition/v2/VisualRecognitionIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/visual_recognition/v2/VisualRecognitionIT.java @@ -49,6 +49,7 @@ public void setUp() throws Exception { service.setUsernameAndPassword(getValidProperty("visual_recognition.v2.username"), getValidProperty("visual_recognition.v2.password")); service.setEndPoint(getValidProperty("visual_recognition.v2.url")); + service.setDefaultHeaders(getDefaultHeaders()); } /** From 43e5e5150e9444007255290c9b1229967899c927 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 23:18:50 -0500 Subject: [PATCH 08/29] [language-translation] Allow more than one file to be used when creating a model, fix #172 --- .../language_translation/v2/LanguageTranslation.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java index fb6712f5568..3c9553eda36 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java +++ b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java @@ -112,10 +112,10 @@ public TranslationModel createModel(CreateModelOptions options) { if (options.getForcedGlossary() != null) bodyBuilder.addFormDataPart(FORCED_GLOSSARY, options.getForcedGlossary().getName(), RequestBody.create(HttpMediaType.BINARY_FILE, options.getForcedGlossary())); - else if (options.getMonolingualCorpus() != null) + if (options.getMonolingualCorpus() != null) bodyBuilder.addFormDataPart(MONOLINGUAL_CORPUS, options.getMonolingualCorpus().getName(), RequestBody.create(HttpMediaType.BINARY_FILE, options.getMonolingualCorpus())); - else if (options.getParallelCorpus() != null) + if (options.getParallelCorpus() != null) bodyBuilder.addFormDataPart(PARALLEL_CORPUS, options.getParallelCorpus().getName(), RequestBody.create(HttpMediaType.BINARY_FILE, options.getParallelCorpus())); From 140bfa4dc78ab06f825c3f83187f69bb4b45467d Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Mon, 8 Feb 2016 23:20:11 -0500 Subject: [PATCH 09/29] Fix for java.naming.InitialContext that was preventing android users from using the sdks #167 --- .../developer_cloud/util/CredentialUtils.java | 25 ++++++++++++------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/util/CredentialUtils.java b/src/main/java/com/ibm/watson/developer_cloud/util/CredentialUtils.java index 1fb653d31e1..7457bb2bd73 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/util/CredentialUtils.java +++ b/src/main/java/com/ibm/watson/developer_cloud/util/CredentialUtils.java @@ -117,20 +117,27 @@ public static String getAPIKey(String serviceName, String plan) { /** * Attempt to get the Base64-encoded API key through JNDI + * * @param serviceName Name of the bluemix service * @return The encoded API Key */ - private static String getKeyUsingJNDI(String serviceName){ - try{ - Context context = new InitialContext(); - String lookupName = "watson-developer-cloud/" + serviceName + "/credentials"; - String apiKey = (String) context.lookup(lookupName); - return apiKey; - }catch(NamingException e){ - //ignore - return null; + private static String getKeyUsingJNDI(String serviceName) { + try { + Class.forName("javax.naming.Context"); + try { + Context context = new InitialContext(); + String lookupName = "watson-developer-cloud/" + serviceName + "/credentials"; + String apiKey = (String) context.lookup(lookupName); + return apiKey; + } catch (NamingException e) { + return null; + } + } catch (ClassNotFoundException exception) { + log.info("JNDI string lookups is not available."); } + return null; } + /** * Gets the VCAP_SERVICES environment variable and return it as a {@link JsonObject}. * From f43770cf7a2edbff041f333002f9ae0609c54d25 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 00:18:02 -0500 Subject: [PATCH 10/29] Updated authorizations keys in travis --- .travis.yml | 3 +-- config.properties.enc | Bin 3616 -> 3648 bytes 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index ce050d76918..7105be3b071 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,9 +9,8 @@ cache: directories: - $HOME/.m2/repository before_install: +- '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && openssl aes-256-cbc -K $encrypted_a973fe4f8e79_key -iv $encrypted_a973fe4f8e79_iv -in config.properties.enc -out src/test/resources/config.properties -d || true' - pip install --user codecov -- openssl aes-256-cbc -K $encrypted_a973fe4f8e79_key -iv $encrypted_a973fe4f8e79_iv - -in config.properties.enc -out src/test/resources/config.properties -d notifications: email: false env: diff --git a/config.properties.enc b/config.properties.enc index fde13015d00c3623ccd70ad311bff6a3b84e1025..2446665679ed27c5203265b73ed65747b9840edb 100644 GIT binary patch literal 3648 zcmV-G4!`lSBjoLfDkH0tgI~d#h;`!+CeNouO0j@{5#77uaXAF6suQJAeb_rR&2O*( zijS?g#zf;XDc_B&$GC`RO{XBZt`iimVhn;tIqAidT07*?fm$|F$|MlKGh$ z&=0A-6F9^c%t8yFdKt1gO)cL-C&kyBBsG(avp+eIN2P@+b{0zF&piGth6&ast)LHgX4YJL)>iu)<>JT9M?&W0AdQQoY$7#pyL*oB2jr2)< z?JOc`R^}EO6X$6 zuA&B*9VcjJygDY*^k2{d=v7LLX{mYRk{Y^X?iVV%D0xp0wiegOy8l2OnSUg&h7rCP zKMuVzt&E&5&_E0K&v<>i9;0RF=9JgLx2PMmQ_w5VeTInUm)Xk?W&TZ!!kFu7#TTgx z&R6Hisujh&j!~7R-nzF8&%zzX4n-gpi&x`S!TMOMw;KEvBl-)LxgqqkpfIRQLx>LW zMaq0nH3tlQm2J_|GnkLB4DWW6x1zo-ycx!Uo(S5QMfSqFp>HU(IWyyCDRD#umzia$ z)wxY1&=#Sc`6uW8FaM;;p9*TJ6J%oOVf8VPXpxQivzE-r&79}n^UT)Taa+vCx{#ps zJ~CWZ{ywQ}Fw&RM+K}mP57Ao@T44H7Q>H3p4%ZE)NH=**ZOPMQM6#6db&6VX|MnU< zYY-!4Jr1h({Oy;u18|;D`-o5AF%l|c3IhG^$ERtD{h&Ix_m*!0wOHW&>kTkF*d#xg zA0s{S*Z47y?QWQJZ;jO;W}$;c>cm%Y>>M?ge3jYFW2O7+e>d; zp*D_I&IBBup<&B9%hENvaxCL;D3!wC=A82&h85g%g$hTVdsLIE?H`t)5v2`~%N)(! z>l-QK*64tP{e*!L%qZQTTnctggEKFpZAVQdnYpLV^opLqy6=u#|w76x7w-6 zxv-haTgH9Dhmd84Gnh`IFc0RVK)KtnZ{2B{<>KVGrQ{V>U&SKy#;jhTF(){(o7X|r z|9@k#3iHgFhhLaojc^RRWcvUS0{Y)ACa__2&M`8je?5L{9PyL&&lCGe29FS)Z;tF= zAna@s{T*#T4e0-=fn=NJNS`$Ou#VTcjHs5i_E>=qARFArXFBbi~;<&LLkDH7(M^yIc`tm2k(HJ6MpErk$Ga zhcq|Z0`sc5Fm4+6y=g4Ff8BXz!l~0(jTVIts#7Ed?hq-k>D`Q}RmyL7iePQ`dM|K^ zD)4=~^+PQT^puN++gJR=LtoSF+KI+xCLW4KYT6D1=GqGtTL|9qtzXW= z&O33f;)K#kKi#j1H&q1;VDiO8Du}S%#(ikzCqzYlTh`9OLqxKi5r42U8qxRQao8IM z#{?N#nJ>Vh(vk-TFYzN$hKcOvw7Chlrt?XA`;&iX>*1~v-z*7gn0k;LkAqu#*_U%= znDO-R4YR*4)6pdBWBgQ*2p~n+b7_0;ccMX>ZmKk>qdQ7R{U6;LBJcF%x|Zc~OF3A% z|7}%vry{a_o{xym44b$M@_wfF;JUfMZ)2k`04_{hbB;e2s^V>oTgR(LW++cS{Ej3I z2$X-}d%{9b*V=|5ZHd<{>OcjdMtvr+uYxye*gR^2xv&xZ?XAy?KpPj z=+G=@^`KVLIJCo=W6O4NA&%BxMGjbjcas1!s$GNYb|xjkvExvF2zK(z!YS#Rc=>(M zwK2tl^f(L4qK)rbM|kkqJu6W{>pWLb z22E=m%7D5nR;|r2)`2K*HzO|l*;Sg_D7@o<^kV|AgewNNLqpN+v~&L zcrS3mg{I^C!250Wj7y7NWh4SmHD&l)C_zVv09DBYG#D0|HDKWlJj^{xMhn@+q4zu? znmTY=Y*pSKnM^7I=@YHuRIq;&pBWv*l8 z+_>wUozIT(*5MA+Kmxohvt57b6V)8$u<6x%4DPg<$)Y)V*xj&Y=n^IVPCG&Ko}iJW zXRo>6X$icI#XM$OqHkHkV&3HHY)sl1X%_~P>c=-nhW*v#wh`Iq3KTI5_mDIohzD*e zhm&w2r5WS``Y9V8Z{UNP2AR{fX8hw>+BT%lc{NFDNJzvGjzqX}CGUH4WiZyN4^ZUj zR*}CmiP6=p;~+X}d;64ij$l23`<8T!z-cTz%@bTNlG#zGB`ZFa3IP&#EJuX62^NT1 z0$pMQF?RQFX1tGZ`M3CwkGI``>--B_LL)j4 z2uR!bd>1$;c}Wx6&%W?mt&=D~Nrms?Pb)TvR<@W?xY93W45>RuY>m$n4aWPJyvz{a zO2v0=;h}%l_%rvssHw4s26Vv&7zR(M+mFA;fYCPjCy|QdQ^%9Qp{Kc{i7XJ_Yc1wT zuZNL0D&N!-<0cFl)I!oS8r-(s?Z-_M@+4sq#+j`~1Fmh#&mv@*LV&tUT79to%Hsh) zJbwb0FO+zb;MN*0WLcV<@NYPJw4@YQ_Rk~uW1zPMz%Y6iTB<63CA~E*YL-&4Qv8JL zR^pUJQg)M{AamjM5NstAR+WIzpZwF+gNOiDFj^orhigqBhj$bXgaSg4MPd2FPS>xY zUaRjdJ{ze308!e0c4UvHxYouH(~AgRI)B>UamB#+iD?wNsY-uhl0IR5u?kNqpxq1+ zSni-B-zL0%{-1I$Wuj)dh$2o4iKEluX-@EH7d9mp^6>LCP$99e{OsRiMxfbAnpZ;m z@;US8X@e|hErQ58t4`tUzB8%t7`SFo?s%%Uq0`6a zQ_RXT7EkM3#!U{{Nhag@tTB*C`~5XBvizO)z$keLXoO(@(3P{{bmP4*XM{UwJWl|7#K*nTgl9SL+HR`wKrZXeF9;XW6xpr+SC7IBwOnive z4QUVjyiUU6pKxr)R$b$nZ9|jjGw#>}q~apvET#iQ)>1z1r#RE!x@=`!P$!PnJ1tm1 z@ZGoDwAY4hdK}?z9Ml5|ZD|e<@x%kSldLV+S!FYzX#s^X{w-ffS5L2jFwo?UYzCwF zOhlVUs6v8g1R`d zt@E^py(x2J7y%?uM2V-g8h)-LOOi`-qoXADcICOKE|!45iv|?XE+lTKrFM}9@4CLO z(BfVjuet?JdV{M0>`CgpXZ&_B55@`?kL!Jl=i0`l4@cGI3j^CaRT6iO`u32lI!WTt zd-WD&AQ3ishNji{p^*GP_D^Oy4#{>9SZH4~p1P(8w&oxyYe$&0;VY%I+q!Oe*eX^% z$x61m97`5*Dv|ON)FaxGtl^iXT9G%)u#D-4)-tb=d=FH~0r)^yZ~3(Xo}B6v`=L(K z)S*rLo9RN()0?!Fp9o66lDDsRDCDKqm{#i z0OE{5f|D&u3}O`K=RPoWclZLt=|UzNnuNUN%boxb^{DXWxHJ1x6)tZb`q_oAAhJ~p z3EXMktbICGBj|Z98hE3y4LAhJTP5>(5(L#X)cnQLQfjn-X(XqY zTWu8{*rY&nZg1wvO7h%y0`uTLHW?fD~@!ZdYI!ARaukBHYWxoN1hySb+K)UzaMf7?2o-pEPD$_KD z%+s~aDcE_|>e9<*`EYK1HZ4-IjfEm`ePnL|}4}2`qbzz5G zU0vA>r!Jd$!{eQ1g)0twG-Fyk4{zzSwZhrgtYN%t9`~1%lvD@piY)T{{jg=x{LuS} zxnZ8k>t8^`@z#mk)JGLMrJ~Zygn)GFGzolYBv)Q3m{0x2%i}M)f$cUdtkx2LDDz`{ z?o&NS4270@Bj6?1sC&h!q7)PZ(yV0x)KA?3+pK|cnzdy3@&Kn>M=Nq3c^TXOl7tD_ zmlx{spKuvgPLQgL)u#TLHire43=*H_IO}Etma|Y@;+?*9Z_8jpB!xC2=mo_RD{s9T zBs;Pl6WG-+EYul4){Dgugo|`rpKv1$jwUuYXN(d(`Cv14iJ~w6%*1JT4%tegz$JZ^ z20QQ(X3=D9Hn1~7@nYKW3$0EdWQ_l$G~4f zP`5F&MUSW%v7)q#P0y6AEgxNbpxipQaj0bPe(LB2wyCMA-TT(xm5m8|qRk^imRLGmS`c1QQ@qi-d1DS%B zm3{C&V5frbs4SS>PSgvUAb`uEkW)h%^4Ywpx{xs1BncAw^2d^2_ z**5wA%dPW&)Ho5%r8TrHXa4WBEhQrjLZ7BFVn!;baME4q{%Oz0h# zp)8j~xyf;7642air9K~LEu?4Ed+-<|8ay75P6AePyM^YB{S>Sda|r_p*rcmR-p$H7 zziG^d#Gw#@Vdp(*KpU*FuZHHHp4yD`;9p=HpvrUw$|F82#J(S5Go*$6R}08vg_v|q116xiNXP0oZ3NLW7w z=8d*PJ%6Z_cyG3_rC|V_4b1r&mrbk4Xcyk|#Ed%Q$TwQUm`v!5xjj1GL(Rfw`Lz4k z5$a7)!*`krz%^D`#DfiLq^NR`Xk=Q;kq)w^kXZSBuwaygt9^(dcK&tdRIFuNE2Yx@ zxtkMGEOJVC!q6WwLC=Po|DXljpO6(H>^5T#%W>0ykunzc=cfqH``X*bLW|p^i<7&bk$%-Um4$_ zn?t=fWIh+E1s5y5u)pS$4DTo{)Dz& zgql&G>0dusF2>iQBEd!QVe4^+!sN>29}PaxlP1;h#?wh)ZyX}Mn^?5H|8`urkBIM! zXB{Y_N+6|ETzbAak`I+%S`@jGy6L}AIZD21cDq*z2mSt9Bs5F=%Z9HvKa-S>$`-O(G2^toMiW!r7J`@&gEv7%1PA`T0&`wi{!uoC4Xf5=;dK zVQ(&RQgO5ie=8d&E#2gltg};XqVIIJ`B%Ncn$Y4yy6n6bVp|XF{YcHuD(wW=`^uo2 zRpDkOsdD8_a~_)9NR)N5lPF!0)EQ{e39j;g4WN7+Flk!^gR`%`puhH;x{PGu^sbc; zfUrdO8;)OnPV8E&0NhR7yZ~3Y&S)hq%u~b7@at7Q1`98{Zs}&4R7)07Zyy?Z7zEk{ z3YNM5!PyPx-in|YO}d4A+Tm|8Q@^T<0O7o~ito!r=ds6djAOnwWeFCcnx;gS+fQP!af!r!I_4ADcdr5yJu`%*%#Xs^= Date: Tue, 9 Feb 2016 00:19:09 -0500 Subject: [PATCH 11/29] [dialog] Deprecate the old method in favor of #177 --- .../com/ibm/watson/developer_cloud/dialog/v1/DialogService.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/ibm/watson/developer_cloud/dialog/v1/DialogService.java b/src/main/java/com/ibm/watson/developer_cloud/dialog/v1/DialogService.java index 1abb8246d15..313c5c3e3bf 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/dialog/v1/DialogService.java +++ b/src/main/java/com/ibm/watson/developer_cloud/dialog/v1/DialogService.java @@ -148,6 +148,7 @@ public Conversation converse(final Conversation conversation, String newMessage) * * @param params the params * @return the {@link Conversation} with the response + * @deprecated Use {@link DialogService#converse(Conversation, String)} */ public Conversation converse(final Map params) { From e5fce41090d22fff52a485d1043ddd63e599914e Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 00:19:56 -0500 Subject: [PATCH 12/29] Close the input stream for JSON HTTP responses after we read the json. --- .../com/ibm/watson/developer_cloud/util/ResponseUtil.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java b/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java index 36298bec68b..2f509e5b477 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java +++ b/src/main/java/com/ibm/watson/developer_cloud/util/ResponseUtil.java @@ -105,6 +105,12 @@ public static T getObject(Response response, Class t } catch (IOException e) { log.log(Level.SEVERE, ERROR_MESSAGE, e); throw new RuntimeException(ERROR_MESSAGE, e); + } finally { + try { + response.body().close(); + } catch (IOException e) { + log.log(Level.SEVERE,"Error closing the HTTP Response", e); + } } } From bbb6e9a17009933bf3145a1995405b058249d408 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 00:20:37 -0500 Subject: [PATCH 13/29] [language-translation] Sleep for 3 seconds after creating a model to be able to delete it without a 404 in the integration tests --- .../language_translation/v2/LanguageTranslation.java | 8 +++++--- .../language_translation/v2/LanguageTranslationIT.java | 3 +++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java index 3c9553eda36..93a65803ae4 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java +++ b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java @@ -208,9 +208,11 @@ public List getModels(final Boolean showDefault, final String */ @SuppressWarnings("unchecked") public List identify(final String text) { - final Request request = - RequestBuilder.post(PATH_IDENTIFY).withBodyContent(text, HttpMediaType.TEXT_PLAIN) - .withHeader(HttpHeaders.ACCEPT, HttpMediaType.APPLICATION_JSON).build(); + final Request request = RequestBuilder + .post(PATH_IDENTIFY) + .withHeader(HttpHeaders.ACCEPT, HttpMediaType.APPLICATION_JSON) + .withBodyContent(text, HttpMediaType.TEXT_PLAIN) + .build(); final LanguageList languages = executeRequest(request, LanguageList.class); diff --git a/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java b/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java index da5c18d17e4..0a4e2b90a46 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationIT.java @@ -72,7 +72,10 @@ public void testCreateAndDeleteModel() { TranslationModel model = null; try { model = service.createModel(options); + Thread.sleep(3000); assertNotNull(model); + } catch (InterruptedException e) { + e.printStackTrace(); } finally { if (model != null) service.deleteModel(model.getId()); From 137131d8bb7ed3885884fdcc3696fd6c4ece5d17 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 09:11:27 -0500 Subject: [PATCH 14/29] Fix default headers replacing existing headers in WatsonService --- .../v2/LanguageTranslation.java | 15 +++++++-------- .../developer_cloud/service/WatsonService.java | 3 ++- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java index 93a65803ae4..cb34184350e 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java +++ b/src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java @@ -39,8 +39,8 @@ * identifies the language in which text is written. * * @version v2 - * @see + * @see * Language Translation */ public class LanguageTranslation extends WatsonService { @@ -208,11 +208,9 @@ public List getModels(final Boolean showDefault, final String */ @SuppressWarnings("unchecked") public List identify(final String text) { - final Request request = RequestBuilder - .post(PATH_IDENTIFY) + final Request request = RequestBuilder.post(PATH_IDENTIFY) .withHeader(HttpHeaders.ACCEPT, HttpMediaType.APPLICATION_JSON) - .withBodyContent(text, HttpMediaType.TEXT_PLAIN) - .build(); + .withBodyContent(text, HttpMediaType.TEXT_PLAIN).build(); final LanguageList languages = executeRequest(request, LanguageList.class); @@ -278,8 +276,9 @@ private TranslationResult translateRequest(String text, String modelId, String s paragraphs.add(new JsonPrimitive(text)); contentJson.add(TEXT, paragraphs); - final RequestBuilder requestBuilder = RequestBuilder.post(PATH_TRANSLATE); - + final RequestBuilder requestBuilder = RequestBuilder.post(PATH_TRANSLATE) + .withHeader(HttpHeaders.ACCEPT, HttpMediaType.APPLICATION_JSON); + if (source != null && !source.isEmpty()) contentJson.addProperty(SOURCE, source); diff --git a/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java b/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java index 2f31c03d8de..6a4c5a3595b 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java +++ b/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java @@ -105,7 +105,8 @@ protected Response execute(Request request) { // Set default headers if (defaultHeaders != null) { - builder.headers(defaultHeaders); + for(String key: defaultHeaders.names()) + builder.header(key, defaultHeaders.get(key)); } // Set User-Agent From cc27cb9fc50a32e5947fd676cedab156f076a8b8 Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 14:41:03 -0500 Subject: [PATCH 15/29] Create REReturnType.java --- .../relationship_extraction/v1/REReturnType.java | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java new file mode 100644 index 00000000000..2d85ff24207 --- /dev/null +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java @@ -0,0 +1,4 @@ +public enum REReturnType { + XML, + JSON +} From 46c1441fd68f140388eb9d12c57f5f6afc5973fb Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 14:51:48 -0500 Subject: [PATCH 16/29] #184 make sure it runs in java 1.6 --- pom.xml | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index 24923451694..6f50251629a 100644 --- a/pom.xml +++ b/pom.xml @@ -1,5 +1,6 @@ - + 4.0.0 com.ibm.watson.developer_cloud 2.7.1-SNAPSHOT @@ -179,10 +180,10 @@ jacoco-maven-plugin 0.7.5.201505241946 - - com/ibm/watson/developer_cloud/*/v*/model/**/*.class - com/ibm/watson/developer_cloud/**/*Example.* - + + com/ibm/watson/developer_cloud/*/v*/model/**/*.class + com/ibm/watson/developer_cloud/**/*Example.* + @@ -199,6 +200,26 @@ + From d74517ed066ab15d7613f3fbb203635e21ae7af1 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 14:52:25 -0500 Subject: [PATCH 17/29] [speech-to-text] Fix for WebSocket being disconnected during final results. #182 --- .../v1/websocket/WebSocketSpeechToTextClient.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java b/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java index 730f5b789be..8e09fb96648 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java +++ b/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java @@ -69,10 +69,6 @@ public void onTextMessage(WebSocket websocket, String message) { } else if (json.has(RESULTS)) { SpeechResults transcript = GsonSingleton.getGson().fromJson(message, SpeechResults.class); delegate.onMessage(transcript); - - // if final is true - if (transcript.isFinal()) - websocket.disconnect(); } } catch (JsonParseException e) { new RuntimeException("Error parsing the incoming message: " + message); From eca25cc9d652852fe44557cf264def7e558ab68d Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 14:59:26 -0500 Subject: [PATCH 18/29] Update REReturnType.java --- .../relationship_extraction/v1/REReturnType.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java index 2d85ff24207..8be2e90bd5d 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java @@ -1,3 +1,5 @@ +package com.ibm.watson.developer_cloud.relationship_extraction.rereturntype; + public enum REReturnType { XML, JSON From 1e45a23d72b700c2481c532df0f2f8539ed62c6a Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:01:37 -0500 Subject: [PATCH 19/29] Update REReturnType.java --- .../relationship_extraction/v1/REReturnType.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java index 8be2e90bd5d..e4706c5e15f 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java @@ -1,4 +1,4 @@ -package com.ibm.watson.developer_cloud.relationship_extraction.rereturntype; +package com.ibm.watson.developer_cloud.relationship_extraction.v1; public enum REReturnType { XML, From 73b1e0c3392b2f0ccf505d6b6b2ad1e8715bfe78 Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:10:52 -0500 Subject: [PATCH 20/29] Update RelationshipExtraction.java --- .../v1/RelationshipExtraction.java | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java index c18051bd5bd..361f45f9a9d 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java @@ -38,6 +38,9 @@ public class RelationshipExtraction extends WatsonService { /** The dataset. */ private Dataset dataset; + + /** The return type. */ + private String returnType; /** * Instantiates a new relationship extraction service. @@ -65,7 +68,7 @@ public RelationshipExtraction() { * * @param text the text to analyze * - * @return the result as XML string + * @return the result as an XML/JSON string */ public String extract(final String text) { Validate.notNull(dataset, "dataset cannot be null"); @@ -73,7 +76,7 @@ public String extract(final String text) { final Request request = RequestBuilder.post("/v1/sire/0") - .withForm("sid", dataset.getId(), "rt", "xml", "txt", text).build(); + .withForm("sid", dataset.getId(), "rt", returnType, "txt", text).build(); final Response response = execute(request); return ResponseUtil.getString(response); } @@ -96,5 +99,18 @@ public Dataset getDataset() { public void setDataset(final Dataset dataset) { this.dataset = dataset; } + + /** + * Sets the returnType. + * + * @param returnType the new returnType + */ + public void setReturnType(final REReturnType returnType) { + if (returnType == REReturnType.XML) { + this.returnType = "xml"; + } else if (returnType == REReturnType.JSON) { + this.returnType = "json"; + } + } } From abd876a4b6eb554e89f11f8f8ffed712fa0b52d6 Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:13:33 -0500 Subject: [PATCH 21/29] Update RelationshipExtraction.java --- .../relationship_extraction/v1/RelationshipExtraction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java index 361f45f9a9d..cdf1c5e2923 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java @@ -40,7 +40,7 @@ public class RelationshipExtraction extends WatsonService { private Dataset dataset; /** The return type. */ - private String returnType; + private String returnType = "xml"; /** * Instantiates a new relationship extraction service. From c2cb059fc9067e33db63b5c5831a3c2d52c5c9c3 Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:37:47 -0500 Subject: [PATCH 22/29] Update REReturnType.java --- .../relationship_extraction/v1/REReturnType.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java index e4706c5e15f..b4a9dfa5523 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java @@ -1,6 +1,6 @@ package com.ibm.watson.developer_cloud.relationship_extraction.v1; -public enum REReturnType { +public enum ReturnType { XML, JSON } From 850d4c5e2495f8c9697be44661a4dcb2e42b0df0 Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:38:03 -0500 Subject: [PATCH 23/29] Update RelationshipExtraction.java --- .../relationship_extraction/v1/RelationshipExtraction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java index cdf1c5e2923..32303a7a678 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java @@ -105,7 +105,7 @@ public void setDataset(final Dataset dataset) { * * @param returnType the new returnType */ - public void setReturnType(final REReturnType returnType) { + public void setReturnType(final ReturnType returnType) { if (returnType == REReturnType.XML) { this.returnType = "xml"; } else if (returnType == REReturnType.JSON) { From 88b27b4aef1f5f99927613aa48f7f1ef3585e8fd Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:41:14 -0500 Subject: [PATCH 24/29] Rename REReturnType.java to ReturnType.java --- .../v1/{REReturnType.java => ReturnType.java} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/{REReturnType.java => ReturnType.java} (100%) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/ReturnType.java similarity index 100% rename from src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/REReturnType.java rename to src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/ReturnType.java From 81e80b5470d994e71ea2b544342dd32559809cde Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:42:59 -0500 Subject: [PATCH 25/29] Update RelationshipExtraction.java --- .../relationship_extraction/v1/RelationshipExtraction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java index 32303a7a678..85423ac7343 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java @@ -111,6 +111,6 @@ public void setReturnType(final ReturnType returnType) { } else if (returnType == REReturnType.JSON) { this.returnType = "json"; } - } + } } From cbb5fd595eaeef7c47c8b86af447bbdab1620975 Mon Sep 17 00:00:00 2001 From: tanmayb123 Date: Tue, 9 Feb 2016 15:45:34 -0500 Subject: [PATCH 26/29] Update RelationshipExtraction.java --- .../relationship_extraction/v1/RelationshipExtraction.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java index 85423ac7343..e55cb181120 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java +++ b/src/main/java/com/ibm/watson/developer_cloud/relationship_extraction/v1/RelationshipExtraction.java @@ -106,9 +106,9 @@ public void setDataset(final Dataset dataset) { * @param returnType the new returnType */ public void setReturnType(final ReturnType returnType) { - if (returnType == REReturnType.XML) { + if (returnType == ReturnType.XML) { this.returnType = "xml"; - } else if (returnType == REReturnType.JSON) { + } else if (returnType == ReturnType.JSON) { this.returnType = "json"; } } From 5902df2331ca950690702b17bfde296399bc42b1 Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 17:25:15 -0500 Subject: [PATCH 27/29] [speech-to-text] Send close message to the WebSocket once we get the final results --- .../v1/websocket/WebSocketSpeechToTextClient.java | 13 +++++++++---- .../speech_to_text/v1/SpeechToTextIT.java | 3 +-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java b/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java index 8e09fb96648..8f95a2a9002 100644 --- a/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java +++ b/src/main/java/com/ibm/watson/developer_cloud/speech_to_text/v1/websocket/WebSocketSpeechToTextClient.java @@ -42,7 +42,7 @@ public class WebSocketSpeechToTextClient { */ public class WebSocketListener extends WebSocketAdapter { private RecognizeDelegate delegate; - + private boolean audioSent = false; /** * Instantiates a new WebSocket listener. * @@ -51,6 +51,7 @@ public class WebSocketListener extends WebSocketAdapter { public WebSocketListener(RecognizeDelegate delegate) { super(); this.delegate = delegate; + audioSent = false; } /* @@ -69,6 +70,8 @@ public void onTextMessage(WebSocket websocket, String message) { } else if (json.has(RESULTS)) { SpeechResults transcript = GsonSingleton.getGson().fromJson(message, SpeechResults.class); delegate.onMessage(transcript); + } else if (audioSent) { + websocket.sendClose(); } } catch (JsonParseException e) { new RuntimeException("Error parsing the incoming message: " + message); @@ -170,7 +173,10 @@ public void recognize(InputStream stream, RecognizeOptions options, RecognizeDel // 4. Send the input stream as binary data sendInputStream(ws, stream); - + + // 5. Tell the listener that we sent the audio + listener.audioSent = true; + // 5. Send stop message ws.sendText(buildStopMessage()); @@ -217,9 +223,8 @@ private void sendInputStream(WebSocket ws, InputStream stream) throws IOExceptio else ws.sendBinary(Arrays.copyOfRange(buffer, 0, read)); - Thread.sleep(10); + Thread.sleep(20); } - stream.close(); } diff --git a/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java b/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java index beb92da0120..4f17e74a8ed 100644 --- a/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java +++ b/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextIT.java @@ -204,8 +204,7 @@ public void onError(Exception e) { public void onMessage(SpeechResults speechResults) { if (speechResults != null && speechResults.isFinal()) { asyncResults = speechResults; - // System.out.println(speechResults); - lock.countDown(); + //System.out.println(speechResults); } } From 322cbd75f11630b9bce33f242341596486517ddb Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 17:29:59 -0500 Subject: [PATCH 28/29] [maven-release-plugin] prepare release java-sdk-2.7.1 --- pom.xml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index 6f50251629a..a8435de4d6c 100644 --- a/pom.xml +++ b/pom.xml @@ -1,9 +1,8 @@ - + 4.0.0 com.ibm.watson.developer_cloud - 2.7.1-SNAPSHOT + 2.7.1 jar java-sdk Watson Developer Cloud Java SDK @@ -76,7 +75,7 @@ SSH scm:git:git@github.com:watson-developer-cloud/java-sdk.git https://github.com/watson-developer-cloud/java-sdk - HEAD + java-sdk-2.7.1 From e2b404175ff442132045ba19326728b949a6be2c Mon Sep 17 00:00:00 2001 From: German Attanasio Ruiz Date: Tue, 9 Feb 2016 17:30:05 -0500 Subject: [PATCH 29/29] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index a8435de4d6c..f2f705c884e 100644 --- a/pom.xml +++ b/pom.xml @@ -2,7 +2,7 @@ 4.0.0 com.ibm.watson.developer_cloud - 2.7.1 + 2.7.2-SNAPSHOT jar java-sdk Watson Developer Cloud Java SDK @@ -75,7 +75,7 @@ SSH scm:git:git@github.com:watson-developer-cloud/java-sdk.git https://github.com/watson-developer-cloud/java-sdk - java-sdk-2.7.1 + HEAD