Skip to content

Conversation

@lpatino10
Copy link
Contributor

This PR updates Discovery to use the new NLU-based Enrichment models and fixes an issue with adding/updating configurations as described here.

It also adds back the old getProfileAsCSV() method to Personality Insights that had been missing since v4.0.0.

lpatino10 and others added 12 commits December 7, 2017 11:05
* Make sure Travis updates the GitHub pages on tagged commits

* [Gradle Release Plugin] - new version commit:  'java-sdk-4.0.2-SNAPSHOT'.

* Fix change to project version
* Add handwritten method for getting profile in CSV format

* Remove csvHeaders property from ProfileOptions
* Add JDNI test library as gradle dependency

* Add GitHub releases deployment for Travis

* Address review comments

* Fix variable syntax
@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #836 into master will decrease coverage by 0.33%.
The diff coverage is 39.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #836      +/-   ##
============================================
- Coverage      56.5%   56.17%   -0.34%     
+ Complexity     2202     2201       -1     
============================================
  Files           488      496       +8     
  Lines         11821    12014     +193     
  Branches        668      674       +6     
============================================
+ Hits           6680     6749      +69     
- Misses         4755     4879     +124     
  Partials        386      386
Impacted Files Coverage Δ Complexity Δ
.../personality_insights/v3/model/ProfileOptions.java 100% <ø> (ø) 10 <0> (-1) ⬇️
...developer_cloud/discovery/v1/model/Enrichment.java 68.18% <ø> (ø) 8 <0> (ø) ⬇️
...d/personality_insights/v3/PersonalityInsights.java 55.81% <0%> (-33.08%) 10 <0> (ø)
...oud/discovery/v1/model/NluEnrichmentRelations.java 0% <0%> (ø) 0 <0> (?)
...ud/discovery/v1/model/NluEnrichmentCategories.java 0% <0%> (ø) 0 <0> (?)
...cloud/discovery/v1/model/NluEnrichmentEmotion.java 39.13% <39.13%> (ø) 1 <1> (?)
...oud/discovery/v1/model/NluEnrichmentSentiment.java 39.13% <39.13%> (ø) 1 <1> (?)
...loud/discovery/v1/model/NluEnrichmentEntities.java 41.86% <41.86%> (ø) 1 <1> (?)
...discovery/v1/model/NluEnrichmentSemanticRoles.java 43.47% <43.47%> (ø) 1 <1> (?)
...loud/discovery/v1/model/NluEnrichmentFeatures.java 51.16% <51.16%> (ø) 1 <1> (?)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53778c4...3d3abc3. Read the comment docs.

@germanattanasio germanattanasio merged commit 681ce62 into master Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants