Skip to content

Conversation

@Hsaylor
Copy link
Contributor

@Hsaylor Hsaylor commented Sep 8, 2021

Generated SDK release using :
API Defs tag sdk-2021-09-03
Generator tag 3.38.0

Discovery V1 tag sdk-2021-09-03

Service Changes

Assistant V1

  • alt_text property added to Image response type

Assistant V2

  • session_start_time and state properties added to MessageContextGlobalSystem model
  • alt_text property added to Image response type
  • location property of RuntimeEntity model changed from required to optional

Discovery V2

  • Enum update for CreateProjectConstants

NLU

  • Fix for listClassificationsModels through return type change and removal of unnecessary model

STT

  • More languages supported for next generation models

TTS

  • New voice models added

CC, Disco V1, LT, NLC, PI, TA, VisRec V3 & V4

  • No changes

Alt_text property added to Image response type
session_start_time and state properties added to MessageContextGlobalSystem model, alt_text property
added to Image response, location property of RuntimeEntity changed to optional
add CONVERSATIONAL_SEARCH and CONTENT_INTELLIGENCE to CreateProjectConstraints Type enum
fix listClassificationModels return type and remove unnecessary model
add model support for several multimedia and telephony models
added support for the nl-BE_AdeleVoice
bump axios version to fix vulnerability and fix commitizen friendlyness
@Hsaylor Hsaylor requested a review from jeff-arn September 9, 2021 19:25
regenerate with sdk-2021-09-03
Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Requested a small change regarding our dependencies

"browserify": "^16.5.2",
"codecov": "^3.8.1",
"concat-stream": "^2.0.0",
"cz-conventional-changelog": "^3.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this dependency added?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe there was an ask to upgrade the ibm-cloud-sdk-core dependency to the latest version 2.14.3. While the current notation would still install the latest version we don't want users the ability to install a version of the ibm-cloud-sdk-core that still uses a vulnerable version of axios so we should be specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cz-conventional-changelog was added as a fix to the commitizen pipeline. We recommend it's use but weren't including it. It made sense to add it while we were updating the package.json. I got confirmation from @repjarms that it should be included.

Ah good catch, I updated our axios dependency past the vulnerable version, but missed the update on the cloud core itself

Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@Hsaylor Hsaylor merged commit 83f67fa into master Sep 14, 2021
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants