-
Notifications
You must be signed in to change notification settings - Fork 661
Hsaylor 9718 rc #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hsaylor 9718 rc #1111
Conversation
Alt_text property added to Image response type
session_start_time and state properties added to MessageContextGlobalSystem model, alt_text property added to Image response, location property of RuntimeEntity changed to optional
add CONVERSATIONAL_SEARCH and CONTENT_INTELLIGENCE to CreateProjectConstraints Type enum
fix listClassificationModels return type and remove unnecessary model
add model support for several multimedia and telephony models
added support for the nl-BE_AdeleVoice
bump axios version to fix vulnerability and fix commitizen friendlyness
regenerate with sdk-2021-09-03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Requested a small change regarding our dependencies
| "browserify": "^16.5.2", | ||
| "codecov": "^3.8.1", | ||
| "concat-stream": "^2.0.0", | ||
| "cz-conventional-changelog": "^3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this dependency added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I believe there was an ask to upgrade the ibm-cloud-sdk-core dependency to the latest version 2.14.3. While the current notation would still install the latest version we don't want users the ability to install a version of the ibm-cloud-sdk-core that still uses a vulnerable version of axios so we should be specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cz-conventional-changelog was added as a fix to the commitizen pipeline. We recommend it's use but weren't including it. It made sense to add it while we were updating the package.json. I got confirmation from @repjarms that it should be included.
Ah good catch, I updated our axios dependency past the vulnerable version, but missed the update on the cloud core itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Generated SDK release using :
API Defs tag
sdk-2021-09-03Generator tag
3.38.0Discovery V1 tag
sdk-2021-09-03Service Changes
Assistant V1
alt_textproperty added to Image response type
Assistant V2
session_start_timeandstateproperties added toMessageContextGlobalSystemmodelalt_textproperty added to Image response typelocationproperty ofRuntimeEntitymodel changed from required to optional
Discovery V2
CreateProjectConstants
NLU
listClassificationsModelsthrough return type change and removal of unnecessary model
STT
TTS
CC, Disco V1, LT, NLC, PI, TA, VisRec V3 & V4