-
Notifications
You must be signed in to change notification settings - Fork 661
Regenerate sdk release 8 #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
========================================
Coverage ? 83.2%
========================================
Files ? 36
Lines ? 4560
Branches ? 578
========================================
Hits ? 3794
Misses ? 364
Partials ? 402
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good! Be sure to check if everything is working in production tomorrow
|
|
||
| Use the [Assistant][conversation] service to determine the intent of a message. | ||
|
|
||
| Note: You must first create a workspace via IBM Cloud. See [the documentation](https://console.bluemix.net/docs/services/conversation/index.html#about) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is accurate - does v2 have workspaces still?
|
@dpopp07 Does there need to be something in the README about ssl option? Since the code is in base-service it isn't as clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
|
Is this ok to release? |
|
Yes |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Could use validation against ICP