Skip to content

Conversation

@dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Sep 20, 2018

  • Regenerate applicable services
  • Add Assistant V2 + tests
  • Add option to disable SSL

Could use validation against ICP

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b9acff6). Click here to learn what that means.
The diff coverage is 89.13%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #779   +/-   ##
========================================
  Coverage          ?   83.2%           
========================================
  Files             ?      36           
  Lines             ?    4560           
  Branches          ?     578           
========================================
  Hits              ?    3794           
  Misses            ?     364           
  Partials          ?     402
Impacted Files Coverage Δ
assistant/v1.ts 89.8% <ø> (ø)
speech-to-text/v1-generated.ts 84.71% <ø> (ø)
index.ts 92.3% <100%> (ø)
lib/base_service.ts 83.33% <100%> (ø)
assistant/v2.ts 88.63% <88.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9acff6...d33349e. Read the comment docs.

mediumTaj
mediumTaj previously approved these changes Sep 20, 2018
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good! Be sure to check if everything is working in production tomorrow


Use the [Assistant][conversation] service to determine the intent of a message.

Note: You must first create a workspace via IBM Cloud. See [the documentation](https://console.bluemix.net/docs/services/conversation/index.html#about) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is accurate - does v2 have workspaces still?

anweshan
anweshan previously approved these changes Sep 21, 2018
@anweshan
Copy link
Contributor

@dpopp07 Does there need to be something in the README about ssl option? Since the code is in base-service it isn't as clear

@dpopp07 dpopp07 dismissed stale reviews from anweshan and mediumTaj via 911fef9 September 21, 2018 16:31
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mediumTaj
Copy link
Contributor

Is this ok to release?

@dpopp07 dpopp07 merged commit 1ea4a2c into master Sep 24, 2018
@dpopp07 dpopp07 deleted the regenerate-sdk-release-8 branch September 24, 2018 14:13
@dpopp07
Copy link
Contributor Author

dpopp07 commented Sep 24, 2018

Yes

@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants