Skip to content

Regenerate sdk release 9 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2018
Merged

Regenerate sdk release 9 #788

merged 5 commits into from
Oct 10, 2018

Conversation

@dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Oct 8, 2018

  • Regenerate with new changes to service
  • Add deprecation messages for Conversation V1, api_key in VisRec, and LTv2 (there was JSDoc for this but never a console message).

@codecov-io
Copy link

codecov-io commented Oct 8, 2018 •
edited
Loading

Codecov Report

Merging #788 into master will increase coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
+ Coverage   83.27%   83.31%   +0.04%     
==========================================
  Files          36       36              
  Lines        4561     4586      +25     
  Branches      578      583       +5     
==========================================
+ Hits         3798     3821      +23     
  Misses        362      362              
- Partials      401      403       +2
Impacted Files Coverage Δ
text-to-speech/v1-generated.ts 90.56% <ø> (ø) ⬆️
tone-analyzer/v3-generated.ts 87.32% <ø> (ø) ⬆️
visual-recognition/v3-generated.ts 79.5% <ø> (ø) ⬆️
speech-to-text/v1-generated.ts 84.71% <ø> (ø) ⬆️
personality-insights/v3-generated.ts 80.48% <ø> (ø) ⬆️
discovery/v1-generated.ts 72.94% <100%> (+0.8%) ⬆️
visual-recognition/v3.ts 98.07% <100%> (+0.07%) ⬆️
language-translator/v2.ts 85.18% <50%> (-2.82%) ⬇️
conversation/v1.ts 97.36% <50%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c2206...1c4fee6. Read the comment docs.

mediumTaj
mediumTaj previously approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about keeping api_key for compatibility. It's still not clear to me why the Node SDK works for query and federatedQuery without converting the array types to string. Can you make sure this is working?

visual-recognition/v3-generated.ts
export type Options = {
version: string;
url?: string;
api_key?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this to maintain compatibility until next major release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to since it is available in the base class options but I will confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this still transpiles in TypeScript.

@dpopp07 dpopp07 dismissed mediumTaj’s stale review October 9, 2018 16:42

need to make changes in discovery to support arrays

mediumTaj
mediumTaj approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@dpopp07 dpopp07 merged commit 965c86e into master Oct 10, 2018
@dpopp07 dpopp07 deleted the regenerate-sdk-release-9 branch October 10, 2018 15:18
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 3.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germanattanasio germanattanasio Awaiting requested review from germanattanasio

1 more reviewer

@mediumTaj mediumTaj mediumTaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dpopp07 @codecov-io @watson-github-bot @mediumTaj