Skip to content

Conversation

@MasterOdin
Copy link
Contributor

This fixes running the test suite locally when you have not created a test/resources/auth.js script as these two tests (integration/assistant.v2.test.js and integration/compare_comply.test.js) both relied on undefined elements of auth before we hit the describe skip blocks.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #868 into master will decrease coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   89.92%   88.78%   -1.15%     
==========================================
  Files          21       18       -3     
  Lines        3494     3396      -98     
  Branches      298      290       -8     
==========================================
- Hits         3142     3015     -127     
- Misses        346      380      +34     
+ Partials        6        1       -5
Impacted Files Coverage Δ
lib/recognize-stream.ts 20.71% <0%> (-38.58%) ⬇️
speech-to-text/v1.ts 30.13% <0%> (-2.74%) ⬇️
assistant/v2.ts 91.11% <0%> (-2.23%) ⬇️
text-to-speech/v1-generated.ts 94.93% <0%> (-0.34%) ⬇️
assistant/v1.ts 92.39% <0%> (-0.17%) ⬇️
test/resources/auth_helper.js
text-to-speech/v1.ts
lib/synthesize-stream.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162c398...a385669. Read the comment docs.

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just have one change to ensure consistency across the services but other than that, looks good

@dpopp07 dpopp07 merged commit b149671 into watson-developer-cloud:master Apr 24, 2019
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants