Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

SphinxBase API change breaks 0.3.0 #28

Merged

Conversation

@mach-kernel
Copy link
Contributor

mach-kernel commented Jul 16, 2017

Hi there!

It seems that a small API removal over on the side of sphinxbase causes FFI to choke on this while loading the library. I edited the changelog and looked for other references for that binding, but it seems that there weren't any (or maybe I missed one?).

At any rate, this should fix it 馃憤 !

@mach-kernel
Copy link
Contributor Author

mach-kernel commented Jul 16, 2017

Additionally, would it be OK for me to:

  • Update the Travis file with a newer Linux distro since they're about to sunset Ubunty "Precise" for "Trusty"?
  • Newer Ruby versions for test? I'm using on 2.4.x without any problems and I'm assuming any recent users are too

Thanks again 馃樃

@watsonbox
Copy link
Owner

watsonbox commented Jul 25, 2017

Sure, I'd be happy to merge this, and also fine for the Travis env update. Is that the reason for the red build?

@watsonbox watsonbox merged commit 9f237e4 into watsonbox:master Jul 25, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@watsonbox
Copy link
Owner

watsonbox commented Jul 25, 2017

Actually I merged this since the spec fixes I think I'll take a look at and sort out myself (there are several..) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.