SphinxBase API change breaks 0.3.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, would it be OK for me to:
Thanks again 😸 |
|
Sure, I'd be happy to merge this, and also fine for the Travis env update. Is that the reason for the red build? |
|
Actually I merged this since the spec fixes I think I'll take a look at and sort out myself (there are several..) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
It seems that a small API removal over on the side of
sphinxbasecauses FFI to choke on this while loading the library. I edited the changelog and looked for other references for that binding, but it seems that there weren't any (or maybe I missed one?).At any rate, this should fix it 👍 !