Wrong initial color in demo page notification #6

Closed
acroca opened this Issue Nov 29, 2011 · 3 comments

Projects

None yet

2 participants

@acroca
acroca commented Nov 29, 2011

In the demo page I've selected 'jackedup' and the 'Welcome back' demo is initially green if you run it after the list demo.

How to replicate

  • select jackedup
  • click list of items (or any other non-grey item)
  • click the first one
  • the clour of the notification will change from the previous item color to grey color
@wavded
Owner
wavded commented Nov 29, 2011

ahh right because its transitioning from the last class, i'll take a peak

@wavded wavded added a commit that closed this issue Nov 29, 2011
@wavded Restore original class after completion
Fixes #6
8817213
@wavded wavded closed this in 8817213 Nov 29, 2011
@wavded
Owner
wavded commented Nov 29, 2011

ok, it will restore the original class after completion now BUT there is always the possibility that the next notification (depending on the theme) may occur before the original class is restored. e.g. for the 'jackedup' theme, if you select the success, wait, and then select the log example, it will be fine, but if you click one after another, there is still a little green that will show, which IMO is ok, maybe even desirable in some cases. Thanks for the report.

@acroca
acroca commented Nov 29, 2011

Cool!
It seems is not deployed yet. I'll check again.

On Tue, Nov 29, 2011 at 9:36 AM, Marc Harter <
reply@reply.github.com

wrote:

ok, it will restore the original class after completion now BUT there is
always the possibility that the next notification (depending on the theme)
may occur before the original class is restored. e.g. for the 'jackedup'
theme, if you select the success, wait, and then select the log example, it
will be fine, but if you click one after another, there is still a little
green that will show, which IMO is ok, maybe even desirable in some cases.
Thanks for the report.


Reply to this email directly or view it on GitHub:
#6 (comment)

Albert Callarisa Roca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment