New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'off' exposure mode #116

Closed
waveform80 opened this Issue Jun 29, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@waveform80
Owner

waveform80 commented Jun 29, 2014

As of 1.6, there'll be a discrepancy between the way we handle awb_mode and exposure_mode, and their corresponding "manual" attributes: awb_gains, and shutter_speed:

When awb_mode is 'off', awb_gains manually controls the auto white balance. When awb_mode is anything else, awb_gains reports the gains calculated by the automatic algorithm.

By contrast, when shutter_speed is 0, shutter speed is determined by the algorithm named by exposure_mode. When shutter_speed is anything else, it manually determines the shutter speed.

In 2.0 we should make things consistent: add a "fake" value to EXPOSURE_MODES titled 'off'. When exposure_mode is set to 'off', the shutter_speed property controls the shutter speed used. When exposure_mode is anything else, shutter_speed simply reports the shutter speed used (which exposure_speed currently does). In other words, change _get_shutter_speed to use the implementation of _get_exposure_speed, leave _set_shutter_speed alone, and tweak _set_exposure_mode to set underlying shutter speed to 0 when a value other than 'off' is specified.

@waveform80 waveform80 added this to the 2.0 milestone Jun 29, 2014

@waveform80 waveform80 added the task label Jun 29, 2014

@waveform80 waveform80 self-assigned this Jun 29, 2014

@waveform80 waveform80 added enhancement and removed task labels Aug 2, 2014

@waveform80 waveform80 modified the milestones: 2.0, 1.7 Aug 2, 2014

@waveform80

This comment has been minimized.

Show comment
Hide comment
@waveform80

waveform80 Aug 2, 2014

Owner

Ahh ... apparently there's already an 'off' exposure mode which disables AGC, but I excluded it from picamera because it only appeared to output black when activated. Turns out shutter speed needs to be set explicitly prior to setting exposure mode to off to avoid this. So, this can be added to 1.7 without much issue.

Owner

waveform80 commented Aug 2, 2014

Ahh ... apparently there's already an 'off' exposure mode which disables AGC, but I excluded it from picamera because it only appeared to output black when activated. Turns out shutter speed needs to be set explicitly prior to setting exposure mode to off to avoid this. So, this can be added to 1.7 without much issue.

@waveform80 waveform80 closed this in 98db315 Aug 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment