New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: motion_output do not work with Class/Object which return 0 , is ready solution . #281

Closed
Pe3ucTop opened this Issue Apr 26, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@Pe3ucTop

Pe3ucTop commented Apr 26, 2016

Hello,

I have noticed that motion_output do not work for object/classes which return 0 .
Example is empty Deque class with applied write method.

Inspect encoders.py code and find bug in one place:
Row 836, buggy check: "if motion_output:" which will return False for empty/0 class.
Other place in code there is correct checking: "if motion_output is not None:" which will return True for empty class.

Solution is to change row 836 of encoders.py:
from : " if motion_output: "
to: " if motion_output is not None: "

I tried to do update myself/ push commit to git , but it's look like not allowed.

@Pe3ucTop

This comment has been minimized.

Pe3ucTop commented Apr 26, 2016

Forgot to mention:
This solution work for me / tested.

@waveform80

This comment has been minimized.

Owner

waveform80 commented May 6, 2016

Good point - I'll get this fixed for 1.11

@waveform80 waveform80 added this to the 1.11 milestone May 6, 2016

@waveform80 waveform80 added the bug label May 6, 2016

@waveform80 waveform80 self-assigned this May 6, 2016

@waveform80 waveform80 closed this in d55c58b May 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment