Fix node-compress compiling #13

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants

I've updated the compress.cc code to handle the removal of node_events.h. I'm not 100% sure Iv'e done this correctly, but the test scripts seem to work.

FWIW, I found this post helpful: [http://permalink.gmane.org/gmane.comp.lang.javascript.nodejs/28298]

Also I noticed that after locally running node-waf configure && node-waf build that the sym link path is changed to build/Release/compress versus build/default/compress.

Can you duplicate this and do we need to fix? Ty.

madhums commented Nov 20, 2011

Yeah, it should be build/default/compress otherwise I am getting "Cannot find module 'compress'" error.

madhums and others added some commits Nov 20, 2011

@abh abh referenced this pull request Dec 30, 2011

Open

Won't build with node 0.6.0 #12

panosru commented Jan 26, 2012

Will this pull request be merged or no? compress won't run with node 0.6 :(

@ghost

ghost commented May 10, 2012

Is there anyway to use your fork @elliotttf to install a package that is dependent on compress?

madhums commented May 10, 2012

Yes @ecoffey-trada . You can use it like this

Put this in your package.json

"compress": "git+ssh://git://github.com/elliotttf/node-compress.git"
@ghost

ghost commented May 10, 2012

Thanks @madhums :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment