Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

/close returns an object and closes the transaction #19

Closed
cactus opened this Issue Oct 10, 2012 · 3 comments

Comments

Projects
None yet
2 participants

cactus commented Oct 10, 2012

I was trying to /close a message but not get the next one yet.

stats
STAT queue_job_queue_items 2
STAT queue_job_queue_waiters 0
STAT queue_job_queue_open_transactions 0
END

get job_queue/open
VALUE job_queue 0 32
{"url": "http://www.google.com"}
END

stats
STAT queue_job_queue_items 1
STAT queue_job_queue_waiters 0
STAT queue_job_queue_open_transactions 1
END

get job_queue/close
VALUE job_queue 0 32
{"url": "http://www.google.com"}
END

stats
STAT queue_job_queue_items 0
STAT queue_job_queue_waiters 0
STAT queue_job_queue_open_transactions 0
END

It looks like /close is returning a message, as well as closing the transaction (and not opening a new transaction like /close/open would).

Is this expected behavior?

Contributor

erikfrey commented Oct 10, 2012

Good catch! Yeah, it's interpreting it as "close the last transaction and also get the next item", which is wrong and not what Kestrel does. I'll post a test and a fix in the next day or two, thanks.

@erikfrey erikfrey closed this in 0132f68 Oct 17, 2012

Contributor

erikfrey commented Oct 17, 2012

@cactus 0132f68 ought to do the trick for you.

cactus commented Oct 18, 2012

Thanks Erik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment