Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify forking process #43

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Conversation

nphilbrook
Copy link
Contributor

@nphilbrook nphilbrook commented Dec 23, 2022

While running through the process, I hit a couple snags. Hopefully this is an improvement, feedback welcome.

Example error if you have more than one yaml file in the requests/forks dir:
https://github.com/wayfair/ospo-automation/actions/runs/3759184483/jobs/6388432898

@lhasa-ospo
Copy link
Contributor

🚨 Hey @nphilbrook, looks like there was an issue processing your fork request! Please ensure you've committed a properly-formatted YAML (.yml) file to the requests/fork/ directory.

@lelia lelia self-requested a review January 3, 2023 18:30
Copy link
Collaborator

@lelia lelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback much appreciated - thanks for your contribution! 🎉

@lelia lelia merged commit a23b700 into main Feb 10, 2023
@lelia lelia deleted the nphilbrook_PLATPC-1799_update_fork_docs branch February 10, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants