New footnotes configuration option: BACKLINK_TEXT (second try) #65

Merged
merged 2 commits into from Dec 28, 2011

2 participants

@startling

BACKLINK_TEXT specifies the text that's used in the link at the end of
the footnote to link back up to the reader's place. It still defaults to "↩".

Since I'm apparently awful at pull requests, I realized the best way to do this was to close the original and start with a clean commit in a new branch. So here's that. Sorry for the confusion and for being confused, and I hope this is helpful.

Here's the original pull request, for future reference.

@startling startling New footnotes configuration option: BACKLINK_TEXT (second try).
BACKLINK_TEXT specifies the text that's used in the link at the end of
the footnote to link back up to the reader's place. It still defaults to
"↩".

Okay, so at first I had an uncessarily complicated commit for this and
submitted a pull request. Waylan showed me a better way to do it, here:

ee7d1a2#markdown/extensions/footnotes.py-P19

So I made another commit and added it to the pull request. But then I
accidentally added yet another commit to the pull request, accidentally.
Since then, I've realized it would be best to start with a new branch
and closed that first pull request.

Hopefully this will be the last try.
7393f58
@waylan

I think you meant to change this line not the next one.

@startling startling fixed an error in the BACKLINK_TEXT option in the footnotes extension.
I accidentally changed the wrong line (L294 instead of L293) to
"self.footnotes.getConfig("BACKLINK_TEXT")" before. This fixes that.
1663d3f
@startling

Yeah, I did.

@waylan waylan merged commit eb1c507 into waylan:master Dec 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment