Skip to content

Waylan Limberg
waylan

Organizations

@markdown @mkdocs
Jun 29, 2016
waylan commented on issue mkdocs/mkdocs#956
@waylan

Just a warning/reminder when someone implements this. Be ware of the recent changes where blocks were added to the template (#947). All JavaScript …

Jun 29, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

The main outstanding question for me is; "what events do we need?" I was intending to go through the history of this discussion and create a summ…

Jun 29, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

I want to avoid running python setup.py install every time we update code. Completely understandable. Which is why Setuptool's Development Mode e…

Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

does this would require that anyone developing a plugin must install it via setuptools? Yes. BTW, Python-Markdown is moving to the same mechanism…

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#985
@waylan

Spotting the duplicated alias would be a useful linter check. Agreed. Unfortunately, this doesn't seem to be in the Markdown linter rules. I chec…

Jun 28, 2016
@waylan
Add rule to detect duplicate reference links.
Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

Search seems like the most obvious candidate. I agree, except that search has a lot of moving parts, including templates, JavaScript, and CSS. Su…

Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

Minor detail question, where does the "registered_plugins" list reside, is it a global variable? I think I would want to build up a dict() of event

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#983
@waylan

Seems reasonable to me.

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#981
@waylan

You have a few typos in the last sentence. Try: Other web servers may be configured to use it but the feature won't always be available. Also, I w…

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#970
@waylan

For the sake of argument, lets assume this is outside of the scope of the Plugin API (see this comment). I still have a few concerns about this PR. …

Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

I generally, like the config file defining the plugin since everything else lives in that file already. One option for my special case is to just …

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#978
@waylan

Just a nitpick, but you don't need the second "Note:" here.

Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

The only problem I see with this is you cannot have a custom yaml loader, because the plugins are defined in the yaml config file. How would you …

Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

some_plugin would be the importable plugin itself (perhaps a module or class??). My initial reaction is that a class would be better, this would…

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#978
@waylan

I just checked my (mostly unused) Bitbucket account and they don't use a separate URL for edits. When you click the [edit] button, the internal con…

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#978
@waylan

This is fine. However, it might be good to point out that a new config setting has been added to make this possible. Maybe add: ... configurable vi…

Jun 28, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

Given that this can be changed in your mkdocs.yml (To switch to edit, you would add: edit_uri: edit/master/docs/), I don't think it really matters…

Jun 28, 2016
waylan edited the mkdocs/mkdocs wiki
Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#977
@waylan

It may just be a cache problem. Try refreshing the page and/or deleting your browser's cache/history. If that doesn't help, your going to need to p…

Jun 28, 2016
waylan commented on issue mkdocs/mkdocs#206
@waylan

I finally took the time to write up a rough draft of my proposal here: Event-Based-Plugin-API. Even if the event-based stuff isn't used, the plugin…

Jun 28, 2016
waylan edited the mkdocs/mkdocs wiki
Jun 28, 2016
waylan created the mkdocs/mkdocs wiki
Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

@d0ugal as far am I'm concerned work on this is done. If your okay with the new setting say the word and I'll merge (or you can merge it yourself).

Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

Sigh. It appears that Page objects are not being tested directly anywhere. Of course, they used to only be simple objects as part of the nav. Howe…

Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

Yes, some more tests would be a good idea. Actually, we should probably add a few tests of the new Page.set_edit_url method as well. Just create a …

Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

This is exactly what I had in mind.

Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

Thanks. This looks good to me. The only concern is that this does add a new config setting. I think its necessary to support the feature, but I wou…

Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

Just took a closer look as this method and I have few concerns: You are using utils.urljoin to join the parts, so you shouldn't need to also be ad…

Jun 27, 2016
waylan commented on pull request mkdocs/mkdocs#975
@waylan

keeping the template changes to a minimum I figured as much. Not a big deal, but with the current changes, if makes sense to clean it up now.

Something went wrong with that request. Please try again.