This should be a user decision #98

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

maletor commented Jun 3, 2013

Conflicts with remotipart

This should be a user decision
Conflicts with remotipart
Owner

waynehoover commented Jun 7, 2013

Can you explain your reasoning a bit more here? I'm happy to hear opinions on this.

maletor commented Jun 7, 2013

It's really just something I need temporarily. We used to use remotipart but because we don't want to upload to our Unicorns directly now, I moved to this gem. Given a big app, it's hard to change all our file uploads at once, so this was a fix to make our application with just Remotipart middleware.

By the way, awesome work with this. IE8 cross origin asynchronous uploads are something that's totally absurd and this gem basically abstracts all that away.

Owner

waynehoover commented Aug 11, 2013

I know its been awhile, but I feel like if we don't include this middleware, then we should at least give some explanation in the readme that uploads in IE might not work unless the user puts this in their stack.

maletor commented Aug 11, 2013

Tend to agree. Middleware injection is the kind of magic I like to know the
slight of hand about.

On Saturday, August 10, 2013, Wayne wrote:

I know its been awhile, but I feel like if we don't include this
middleware, then we should at least give some explanation in the readme
that uploads in IE might not work unless the user puts this in their stack.


Reply to this email directly or view it on GitHubhttps://github.com/waynehoover/s3_direct_upload/pull/98#issuecomment-22451797
.

Contributor

uberllama commented Aug 12, 2013

This sounds like an edge case user specific issue, rather than something that should be changed (broken) for everyone. Perhaps run your own branch?

maletor commented Dec 2, 2015

This is really old so I'm closing it.

@maletor maletor closed this Dec 2, 2015

@maletor maletor deleted the maletor:patch-1 branch Dec 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment