Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when reflecting on associations. #51

Merged
merged 1 commit into from Nov 28, 2014

Conversation

@joeyates
Copy link

@joeyates joeyates commented Nov 28, 2014

* `:through` values should be symbols (see
  https://github.com/rails/rails/blob/4-1-stable/activerecord/lib/active_record/reflection.rb#L25),
* this was causing errors in ActiveAdmin.
@wazery
Copy link
Owner

@wazery wazery commented Nov 28, 2014

@joeyates Thanks for your PR, appreciated!

wazery added a commit that referenced this pull request Nov 28, 2014
Fix error when reflecting on associations.
@wazery wazery merged commit 170ac92 into wazery:master Nov 28, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@wazery wazery added this to the 1.1.0 milestone Nov 28, 2014
@wazery wazery added the bug label Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.