Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-1233 ring group user timeout #140

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WP-1233 ring group user timeout #140

wants to merge 5 commits into from

Conversation

DrPyser
Copy link
Contributor

@DrPyser DrPyser commented Jan 29, 2024

No description provided.

@DrPyser DrPyser changed the title Wp 1233 ring group user timeout WP-1233 ring group user timeout Jan 29, 2024
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/82dc3e31eae04ed395702f4f78eee327

❌ tox-linters FAILURE in 6m 25s
✔️ wazo-tox-py39 SUCCESS in 6m 42s
❌ wazo-tox-integration-py39 FAILURE in 3m 26s
✔️ debian-packaging-bullseye SUCCESS in 2m 09s

@DrPyser DrPyser force-pushed the WP-1233-ring-group-user-timeout branch 2 times, most recently from 6d59ba8 to 5935ad9 Compare January 29, 2024 19:36
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/280d7f34c0254f2a839c3bd6b518da53

❌ tox-linters FAILURE in 6m 20s
✔️ wazo-tox-py39 SUCCESS in 6m 37s
❌ wazo-tox-integration-py39 FAILURE in 3m 13s
✔️ debian-packaging-bullseye SUCCESS in 2m 04s

@DrPyser DrPyser force-pushed the WP-1233-ring-group-user-timeout branch from 5935ad9 to 4d86e5c Compare January 29, 2024 21:12
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/7a26617d8f84403aa97107cb6864c8d2

❌ tox-linters FAILURE in 6m 23s
✔️ wazo-tox-py39 SUCCESS in 6m 36s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 36s
✔️ debian-packaging-bullseye SUCCESS in 2m 17s

pc-m
pc-m requested changes Jan 30, 2024
View reviewed changes
wazo_agid/handlers/groupfeatures.py Outdated Show resolved Hide resolved
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/a4bb8bf5963140a2aeef9153e4e5d8fb

❌ tox-linters FAILURE in 6m 18s
✔️ wazo-tox-py39 SUCCESS in 6m 31s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 17s
✔️ debian-packaging-bullseye SUCCESS in 2m 09s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/ac7ae67ab9db40fa93c4e08dc3878ed1

✔️ tox-linters SUCCESS in 6m 09s
✔️ wazo-tox-py39 SUCCESS in 6m 28s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 36s
✔️ debian-packaging-bullseye SUCCESS in 2m 15s

@DrPyser DrPyser requested a review from pc-m January 30, 2024 21:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/bc5e9151ddbc4344bd8ad5428f84de88

✔️ tox-linters SUCCESS in 4m 26s
✔️ wazo-tox-py39 SUCCESS in 4m 21s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 24s
✔️ debian-packaging-bullseye SUCCESS in 2m 09s

sboily
sboily requested changes Feb 2, 2024
View reviewed changes
wazo_agid/handlers/groupfeatures.py
@@ -111,9 +115,10 @@ def _set_members(self) -> None:
self._write_calling = res['write_calling']
self._ignore_forward = res['ignore_forward']
self._preprocess_subroutine = res['preprocess_subroutine']
self._musicclass = res['musicclass']
self._musicclass = res['queue_musicclass']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix need to be documented in another ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboily sboily sboily requested changes

@pc-m pc-m Awaiting requested review from pc-m

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DrPyser @pc-m @sboily