Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands.calls.connect_user: Added support for arbitrary body attributes #55

Merged
merged 2 commits into from Jan 31, 2024

Conversation

DrPyser
Copy link
Contributor

@DrPyser DrPyser commented Jan 24, 2024

Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/7c116b1da90948009a010501b5cccb4f

✔️ tox-linters SUCCESS in 5m 34s
wazo-tox-py39 FAILURE in 5m 06s
✔️ debian-packaging-bullseye SUCCESS in 1m 50s

Why: future-proof if new attributes need to be supported, avoid rencoding too much API schema, backward compatible(no kwargs retain existing behavior)
@DrPyser DrPyser force-pushed the WAZO-3259-connect-user-timeout branch from 4c35ff3 to 9ec175b Compare January 26, 2024 14:17
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/305e2e0e786c406b8d778e2d3f7fef4c

✔️ tox-linters SUCCESS in 3m 49s
✔️ wazo-tox-py39 SUCCESS in 3m 26s
✔️ debian-packaging-bullseye SUCCESS in 1m 38s

@@ -99,10 +99,10 @@ def hangup_from_user(self, call_id):
if r.status_code != 204:
self.raise_from_response(r)

def connect_user(self, call_id, user_id):
def connect_user(self, call_id, user_id, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the "doc", i.e. the README, to show how to pass arguments to the endpoint, please?

Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/9d6c1b6425d743e59ddf2c8c1bd35cfb

✔️ tox-linters SUCCESS in 3m 53s
✔️ wazo-tox-py39 SUCCESS in 3m 50s
✔️ debian-packaging-bullseye SUCCESS in 1m 43s

@sduthil sduthil merged commit 8d74eb1 into master Jan 31, 2024
1 of 2 checks passed
@sduthil sduthil deleted the WAZO-3259-connect-user-timeout branch January 31, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants