Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wazo 3259 connect user timeout #305

Merged
merged 10 commits into from Jan 31, 2024
Merged

Wazo 3259 connect user timeout #305

merged 10 commits into from Jan 31, 2024

Conversation

DrPyser
Copy link
Contributor

@DrPyser DrPyser commented Jan 24, 2024 •
edited

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/9440a59df08e4608851293651a683a3e

❌ tox-linters FAILURE in 5m 54s
✔️ wazo-tox-py39 SUCCESS in 6m 01s
✔️ debian-packaging-bullseye SUCCESS in 2m 08s
❌ calld-tox-integration FAILURE in 35m 30s

@DrPyser
plugins.calls.ConnectCallToUserResource: added 'timeout' parameter to…
e5f916e 
… endpoint to control originate timeout behavior

why: ARI hardcodes a default timeout of 30s, which is not satisfying to all use cases
@DrPyser DrPyser force-pushed the WAZO-3259-connect-user-timeout branch from f073fbf to a87f048 Compare January 26, 2024 13:51
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change wazo-platform/wazo-calld-client#55 is needed.

@DrPyser DrPyser force-pushed the WAZO-3259-connect-user-timeout branch from a87f048 to 3c127c1 Compare January 26, 2024 14:40
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/cd0c70f8767d4982a266a353dafecef4

✔️ tox-linters SUCCESS in 4m 24s
✔️ wazo-tox-py39 SUCCESS in 4m 37s
✔️ debian-packaging-bullseye SUCCESS in 2m 46s
❌ calld-tox-integration FAILURE in 35m 24s

@DrPyser
Copy link
Contributor Author

DrPyser commented Jan 29, 2024

recheck

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/09e561c9f3b14cbda617b1f92bf91f20

✔️ tox-linters SUCCESS in 6m 13s
✔️ wazo-tox-py39 SUCCESS in 6m 18s
✔️ debian-packaging-bullseye SUCCESS in 2m 46s
❌ calld-tox-integration FAILURE in 35m 42s

@DrPyser
Copy link
Contributor Author

DrPyser commented Jan 29, 2024 •
edited

Depends-On: wazo-platform/wazo-calld-client#55

@DrPyser
Copy link
Contributor Author

DrPyser commented Jan 29, 2024

recheck

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/ba0615f87dd749799fc17c76fb1fa569

✔️ tox-linters SUCCESS in 6m 22s
✔️ wazo-tox-py39 SUCCESS in 6m 22s
✔️ debian-packaging-bullseye SUCCESS in 2m 49s
❌ calld-tox-integration FAILURE in 35m 11s

sduthil
sduthil requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@sduthil sduthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles!

A few other things are missing:

  • update the API doc
  • update the API changelog
  • Test when timeout is invalid

integration_tests/suite/test_calls.py Outdated Show resolved Hide resolved
wazo_calld/plugins/calls/http.py Outdated Show resolved Hide resolved
wazo_calld/plugins/calls/services.py Outdated Show resolved Hide resolved
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/e26bf4bdfe2a4aa0b3119ed3a68a8db5

❌ tox-linters FAILURE in 6m 13s
✔️ wazo-tox-py39 SUCCESS in 6m 10s
✔️ debian-packaging-bullseye SUCCESS in 2m 44s
❌ calld-tox-integration FAILURE in 35m 47s

@sduthil sduthil force-pushed the WAZO-3259-connect-user-timeout branch from 37b35bc to 6bc2aae Compare January 31, 2024 09:36
sduthil
sduthil previously approved these changes Jan 31, 2024
View reviewed changes
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/5850da823bd54c45a16ccf9be4c7edef

✔️ tox-linters SUCCESS in 6m 21s
✔️ wazo-tox-py39 SUCCESS in 6m 23s
✔️ debian-packaging-bullseye SUCCESS in 2m 54s
❌ calld-tox-integration FAILURE in 35m 46s

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

14.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/270f72d3befb42959844ea7b5444968b

✔️ tox-linters SUCCESS in 6m 14s
✔️ wazo-tox-py39 SUCCESS in 6m 11s
✔️ debian-packaging-bullseye SUCCESS in 2m 46s
✔️ calld-tox-integration SUCCESS in 35m 21s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://zuul.wazo.community/zuul/t/local/buildset/83f63a4f29804c6480f1297b8e551e9d

Warning:
Change 55 in project wazo-platform/wazo-calld-client does not share a change queue with 305 in project wazo-platform/wazo-calld

@sduthil sduthil merged commit 2df3707 into master Jan 31, 2024
1 of 3 checks passed
@sduthil sduthil deleted the WAZO-3259-connect-user-timeout branch January 31, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduthil sduthil sduthil approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
2 participants
@DrPyser @sduthil