Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RBAC experimental API integration test expecting a 1760 code in implicit requests #10322

Merged
merged 3 commits into from Sep 29, 2021
Merged

Fix RBAC experimental API integration test expecting a 1760 code in implicit requests #10322

merged 3 commits into from Sep 29, 2021

Conversation

mcarmona99
Copy link
Contributor

Related issue
#10311

This PR closes #10311.

In this pull request, I have deleted the expected code 1760 in RBAC experimental syscheck test cases of our API integration tests as this code is excluded when using the endpoint with the all keyword (implicit request).

Test results

test_rbac_black_rootcheck_endpoints.tavern.yaml 
	 4 passed, 6 warnings

test_rbac_black_syscheck_endpoints.tavern.yaml 
	 4 passed, 6 warnings

test_rbac_white_rootcheck_endpoints.tavern.yaml 
	 4 passed, 6 warnings

test_rbac_white_syscheck_endpoints.tavern.yaml 
	 4 passed, 6 warnings

test_rootcheck_endpoints.tavern.yaml 
	 4 passed, 6 warnings
	 
test_syscheck_endpoints.tavern.yaml 
	 35 passed, 37 warnings

test_experimental_endpoints.tavern.yaml 
	 11 passed, 1 xpassed, 14 warnings

test_rbac_black_experimental_endpoints.tavern.yaml 
	 12 passed, 14 warnings

test_rbac_white_experimental_endpoints.tavern.yaml 
	 12 passed, 14 warnings

@mcarmona99 mcarmona99 self-assigned this Sep 27, 2021
vicferpoy
vicferpoy previously approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@vicferpoy vicferpoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcarmona99 @davidjiglesias
Update api/test/integration/test_rbac_black_experimental_endpoints.ta…
ff25ef5 
…vern.yaml

Co-authored-by: David Jose Iglesias Lopez <48716145+davidjiglesias@users.noreply.github.com>
@mcarmona99 @davidjiglesias
Update api/test/integration/test_rbac_white_experimental_endpoints.ta…
9d816d7 
…vern.yaml

Co-authored-by: David Jose Iglesias Lopez <48716145+davidjiglesias@users.noreply.github.com>
@davidjiglesias davidjiglesias merged commit fb19bdf into master Sep 29, 2021
@davidjiglesias davidjiglesias deleted the fix/10311-fix-syscheck-experimental-ait branch September 29, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjiglesias davidjiglesias davidjiglesias approved these changes

@vicferpoy vicferpoy vicferpoy left review comments

Assignees

@mcarmona99 mcarmona99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove expected code 1760 in RBAC experimental API integration tests
3 participants
@mcarmona99 @vicferpoy @davidjiglesias