Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wpopenv in AR scripts and escape special characters from JSON alert #10809

Merged
merged 5 commits into from Nov 12, 2021

Conversation

TomasTurina
Copy link
Member

@TomasTurina TomasTurina commented Nov 11, 2021

Related issue
#10858

Description

This PR aims to fix a problem detected in some AR scripts:

  • On the agent side, replace system function calls with wpopenv.
  • On the manager side, escape the following characters in JSON alerts: ! $ ' `

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation
  • Source upgrade

@TomasTurina TomasTurina self-assigned this Nov 11, 2021
@TomasTurina TomasTurina marked this pull request as ready for review November 12, 2021 02:30
@vikman90 vikman90 added type/bug Something isn't working module/active response labels Nov 12, 2021
@vikman90 vikman90 merged commit a121e73 into 4.2 Nov 12, 2021
7 checks passed
@vikman90 vikman90 deleted the 10731_fix_slack_ar branch November 12, 2021 15:29
@ajakk
Copy link

ajakk commented Nov 12, 2021

Can the issue be undeleted now that the PR is public?

@vikman90
Copy link
Member

@ajakk We've restored the issue back at #10858.

Kudos to @rk100 who reported this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/active response type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants