New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress backup files from the report_changes option #2034

Merged
merged 6 commits into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@bah07
Copy link
Member

bah07 commented Dec 4, 2018

Related issue:

  • Compress state files for FIM #706

Description

When the report_changes option is used in FIM, a backup file is created where the contents of the monitored file are stored in order to obtain the differences of the last modification. Now, these files are stored compressed.

Test

  • Check in the alerts that the differences of text files are shown.
  • Check that the compressed files are deleted when the source files are no longer monitored or deleted.
  • Verify that last-entry files are effectively stored compressed with the .gz extension.
  • Check that the functionality of the report_changes option is not affected after this change.

@bah07 bah07 added in review and removed in review labels Dec 4, 2018

@chemamartinez chemamartinez self-requested a review Dec 5, 2018

@chemamartinez
Copy link
Member

chemamartinez left a comment

LGTM!

@chemamartinez chemamartinez force-pushed the issue-706 branch from 892cdfa to dda0869 Dec 5, 2018

@chemamartinez chemamartinez merged commit 461be4b into 3.8 Dec 5, 2018

@chemamartinez chemamartinez deleted the issue-706 branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment