New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for Syscollector DB #674

merged 4 commits into from Jul 27, 2018


3 participants

chemamartinez commented May 25, 2018

This PR adds the following improvements in the process of storing the collected inventory into the agents DBs:

  • If any error appears when a particular scan is being stored in the DB, we don`t store the rest of the data belonging to that scan. This way, we avoid useless queries to the DB wasting its resources and flooding the logs with many error messages.
  • When reading Windows programs inventory from the registry, some programs could be repeated triggering an error from the DB. Now, we skip that program without stopping the programs scan.
  • Syscollector events were being processed by the JSON decoder. This is useless since the Syscollector decoder exists so we avoid parsing syscollector events by the JSON decoder.

@chemamartinez chemamartinez referenced this pull request Jun 5, 2018


Test Syscollector 3.5 #719

7 of 7 tasks complete

@chemamartinez chemamartinez requested a review from vikman90 Jul 25, 2018

@chemamartinez chemamartinez added the bug label Jul 25, 2018

@chemamartinez chemamartinez added this to In review in Wazuh 3.5 via automation Jul 25, 2018

@bah07 bah07 self-requested a review Jul 27, 2018


bah07 approved these changes Jul 27, 2018

Wazuh 3.5 automation moved this from Needs review to Reviewer approved Jul 27, 2018

@bah07 bah07 changed the base branch from master to 3.5 Jul 27, 2018

@bah07 bah07 merged commit eaf6cae into 3.5 Jul 27, 2018

Wazuh 3.5 automation moved this from Reviewer approved to Done Jul 27, 2018

@bah07 bah07 deleted the fix-sysc-db branch Jul 27, 2018

chemamartinez added a commit that referenced this pull request Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment