Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and save the agent group when deliver the keep-alive #9088

Merged
merged 10 commits into from Aug 26, 2021
Merged

Check and save the agent group when deliver the keep-alive #9088

merged 10 commits into from Aug 26, 2021

Conversation

cborla
Copy link
Member

@cborla cborla commented Jun 22, 2021 •
edited

Closes #8974

Description

  • Let Remoted check the agents' group when they deliver the keepalive.

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Centos
    • Source installation
    • Source upgrade
    • Review logs syntax and correct language
  • Memory tests for Linux
    • Scan-build report
    • Valgrind (memcheck and descriptor leaks check)

@cborla cborla linked an issue Jun 22, 2021 that may be closed by this pull request
Let Remoted check the agents' group when they deliver the keepalive #8974
Closed
3 tasks
TomasTurina
TomasTurina requested changes Jun 23, 2021
View reviewed changes
src/remoted/manager.c Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
src/remoted/manager.c Outdated Show resolved Hide resolved
@cborla cborla changed the title 8974 keepalive check agent group 4.2 Check and save the agent group when deliver the keep-alive Jun 24, 2021
@cborla cborla added type/enhancement New feature or request module/remote labels Jun 24, 2021
@TomasTurina TomasTurina self-requested a review June 24, 2021 14:59
TomasTurina
TomasTurina approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@TomasTurina TomasTurina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikman90 vikman90 merged commit 1f6475d into 4.2 Aug 26, 2021
@vikman90 vikman90 deleted the 8974-keepalive_check_agent_group_4.2 branch August 26, 2021 11:40
@vikman90 vikman90 mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTurina TomasTurina TomasTurina approved these changes

@Nicogp Nicogp Awaiting requested review from Nicogp

@javabalm javabalm Awaiting requested review from javabalm

Assignees

@vikman90 vikman90

Labels
module/remote type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let Remoted check the agents' group when they deliver the keepalive
3 participants
@cborla @TomasTurina @vikman90