New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maild log source selection #977

Merged
merged 7 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@TJOSERAFAEL
Copy link
Member

TJOSERAFAEL commented Jul 20, 2018

This PR solves the issue #971

The new option is:
<email_log_source>alerts.log</email_log_source>
OR
<email_log_source>alerts.json</email_log_source>

@TJOSERAFAEL TJOSERAFAEL self-assigned this Jul 20, 2018

@TJOSERAFAEL TJOSERAFAEL added this to In review in Wazuh 3.5 via automation Jul 20, 2018

@TJOSERAFAEL TJOSERAFAEL requested a review from vikman90 Jul 20, 2018

@vikman90 vikman90 moved this from In review to Stall in Wazuh 3.5 Jul 25, 2018

@vikman90 vikman90 removed this from Stall in Wazuh 3.5 Jul 26, 2018

@vikman90 vikman90 added this to In review in Wazuh TBD via automation Jul 26, 2018

@TJOSERAFAEL TJOSERAFAEL removed this from In review in Wazuh TBD Aug 8, 2018

@TJOSERAFAEL TJOSERAFAEL added this to Needs review in Wazuh 3.6 via automation Aug 8, 2018

@vikman90 vikman90 removed this from Needs review in Wazuh 3.6 Aug 13, 2018

@vikman90 vikman90 added this to In progress in Wazuh 3.7 via automation Aug 13, 2018

@vikman90 vikman90 moved this from In progress to Needs review in Wazuh 3.7 Aug 13, 2018

@crolopez crolopez requested review from crolopez and removed request for vikman90 Sep 17, 2018

@crolopez crolopez assigned vikman90 and unassigned TJOSERAFAEL Sep 17, 2018

Wazuh 3.7 automation moved this from Needs review to Reviewer approved Sep 18, 2018

@vikman90
Copy link
Member

vikman90 left a comment

Hi @TJOSERAFAEL,

Let me comment here:

  1. This option disables auto-selection and forces the user to select the correct option if he disables the test output (the most common action). If no explicit option defined (or it has a value like auto ), Maild should select the most appropiate option.

  2. I wonder if JSON should be the default auto-selection option.

  3. We must put this new option into the configuration dumper.

  4. We must fill the reference documentation for this option.

Thank you!

Wazuh 3.7 automation moved this from Reviewer approved to Needs review Sep 20, 2018

@vikman90 vikman90 moved this from Needs review to Backlog in Wazuh 3.7 Sep 20, 2018

@vikman90 vikman90 added this to Needs review in Wazuh 3.8.0 via automation Oct 24, 2018

@vikman90 vikman90 removed this from Backlog in Wazuh 3.7 Oct 24, 2018

@TJOSERAFAEL

This comment has been minimized.

Copy link
Member

TJOSERAFAEL commented Dec 26, 2018

@TJOSERAFAEL TJOSERAFAEL changed the base branch from 3.5 to 3.8 Dec 27, 2018

@chemamartinez chemamartinez added this to the 1st week sprint milestone Dec 31, 2018

@vikman90 vikman90 removed this from the 1st week sprint milestone Jan 8, 2019

@vikman90 vikman90 added this to Needs review in Wazuh 3.9.0 via automation Jan 8, 2019

@vikman90 vikman90 removed this from Needs review in Wazuh 3.8.0 Jan 8, 2019

@vikman90 vikman90 removed this from Needs review in Wazuh 3.9.0 Jan 8, 2019

@vikman90 vikman90 added this to Needs review in Wazuh 3.8.0 via automation Jan 8, 2019

@vikman90 vikman90 added this to the 2nd week sprint milestone Jan 8, 2019

@vikman90 vikman90 removed this from Needs review in Wazuh 3.8.0 Jan 8, 2019

@vikman90 vikman90 removed this from the 2nd week sprint milestone Jan 8, 2019

Show resolved Hide resolved src/os_maild/config.c Outdated

@TJOSERAFAEL TJOSERAFAEL force-pushed the dev-3.5-maild branch from 4e97ae3 to eed8070 Jan 8, 2019

@vikman90
Copy link
Member

vikman90 left a comment

LGTM!

@vikman90 vikman90 merged commit 2ba395f into 3.8 Jan 8, 2019

@vikman90 vikman90 deleted the dev-3.5-maild branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment