Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.subdirs: don't assign ; to DEPFLAGS[123] / QUIET_{CC,CXX} #1008

Closed
wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Collaborator

I believe this fixes #1007 but have not yet verified so (will do next)

@wbhart
Copy link
Collaborator

wbhart commented Oct 15, 2021

Seems to work locally, though I am not clear why the semicolons are required (and clearly ok) on the prior lines, but not on these lines.

@wbhart
Copy link
Collaborator

wbhart commented Oct 15, 2021

If this passes, I'll issue 2.8.2 with this fix.

@wbhart
Copy link
Collaborator

wbhart commented Oct 15, 2021

I wonder if the problem was actually the spaces instead of tabs.

@fingolfin
Copy link
Collaborator Author

I've verified that this patch fixes the compilation issues on Yggdrasil, see JuliaPackaging/Yggdrasil#3750 and the build logs there.

@wbhart
Copy link
Collaborator

wbhart commented Oct 15, 2021

Thanks, that's very helpful. I'll wait for CI to verify the fix here on GitHub and I'll issue the release.

I ended up making the changes by hand locally rather than merging this PR, since I did the release paperwork in the same commit.

@fingolfin fingolfin closed this Oct 15, 2021
@fingolfin fingolfin deleted the mh/semicolons branch October 25, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile.subdirs broken in v2.8.1 tag
2 participants