timestamp check does not allow long #23

Closed
nonnib opened this Issue May 22, 2013 · 2 comments

Projects

None yet

2 participants

@nonnib
nonnib commented May 22, 2013
if not (timestamp is None or isinstance(timestamp, int)):
    raise TypeError("'timestamp' must be an integer or None")

This causes issues for me in Python 2.7.3 on Windows because this is long:

timestamp=1369168852994

Suggested fix:

if not (timestamp is None or isinstance(timestamp, (int, long))):
    raise TypeError("'timestamp' must be an integer or None")
@wbolster wbolster was assigned May 22, 2013
@wbolster
Owner

Confirming, I'm working on a fix.

@wbolster wbolster added a commit that referenced this issue May 22, 2013
@wbolster Also allow 'long' type for 'timestamp' args
Fixes issue #23.
e5419f8
@wbolster wbolster added a commit that referenced this issue May 22, 2013
@wbolster Update NEWS
See issue #23.
5de3f12
@wbolster
Owner

Thanks for the report. The fix will be in the upcoming 0.5 release.

@wbolster wbolster closed this May 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment