Fix broken installation of package dependencies. #1

Merged
merged 2 commits into from May 21, 2012

2 participants

@todddeluca

A common way to break project installation is to import the package in
setup.py in order to get access to mypackage.version. However if
mypackage depends on a different uninstalled package, the import will
fail, causing setup.py to fail before it has a chance to install the
dependency.

The fix is to find some other DRY way to get at version.

For more details see:

Todd DeLuca added some commits May 21, 2012
Todd DeLuca Remove package import for version to fix install.
A common way to break project installation is to import the package in
setup.py in order to get access to mypackage.__version__.  However if
mypackage depends on a different uninstalled package, the import will
fail, causing setup.py to fail before it has a chance to install the
dependency.

The fix is to find some other DRY way to get at __version__.

For more details see:

- http://stackoverflow.com/questions/458550/
- http://stackoverflow.com/questions/2058802/
63573cd
Todd DeLuca Use happybase.version in __init__ to stay DRY. 5366974
@wbolster wbolster merged commit 5366974 into wbolster:master May 21, 2012
@wbolster
Owner

Thanks, I've merged your fix and also updated the installation guide in the docs.

@csabaszilveszter csabaszilveszter referenced this pull request Feb 4, 2016
Closed

Python 3 support #40

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment