Enable building universal wheels #78

Merged
merged 1 commit into from Jun 11, 2015

Projects

None yet

2 participants

@dhellmann
Contributor

Remove the use of execfile() in setup.py so it can run under python 3.

Set the flag in setup.cfg to allow universal wheels.

@dhellmann dhellmann Enable building universal wheels
Remove the use of execfile() in setup.py so it can run under python 3.

Set the flag in setup.cfg to allow universal wheels.
0c7f3d3
@dhellmann
Contributor

Without this change in place, I see this error:

  $ python setup.py bdist_wheel
  Traceback (most recent call last):
    File "setup.py", line 5, in <module>
      execfile('happybase/_version.py')
  NameError: name 'execfile' is not defined
@wbolster
Owner

Thanks!

FYI, Happybase only supported Python 2 because the Thrift library it depends on lacked Python 3 support. It seems that is now a thing of the past.

@wbolster wbolster referenced this pull request Jan 13, 2015
Closed

Python 3 support #40

3 of 3 tasks complete
@dhellmann
Contributor

I wasn't actually able to build wheels at all without the changes to setup.py. The "universal" flag was added as a "bonus".

@wbolster
Owner

I don't understand. Why would execfile fail? In Python 3 that function doesn't exist anymore, but in Python 2 it should be there, right?

@dhellmann
Contributor

Ah, my default pip happens to be configured to point to python3, so if I run "pip wheel happybase" it fails.

@wbolster
Owner

Okay, I will merge this when I find time to get the other stuff required to release a version with Python 3 support done (#40).

@wbolster wbolster merged commit 9cbd718 into wbolster:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment