add ZeitgeistLogger #2919

Merged
merged 3 commits into from Mar 8, 2014

Conversation

Projects
None yet
2 participants
Contributor

jolivares commented Mar 7, 2014

No description provided.

Collaborator

FichteFoll commented Mar 7, 2014

  1. Your Python code is definitely not compatible with Python 3. Please either fix that or adjust the target version.
  2. Since your zeitgeist-logger.py is also Python 2 you should add a shebang line since otherwise a different version (3) might run and it won't work.
  3. There is no mention that your package requires Python to begin with. You should really include that in the readme. Furthermore you import the zeitgeist module which, again, is not mentioned.
  4. I don't exactly know what zeitgeist is but it does not look to be cross-platform. If that's the case, please specify one or multiple target platforms.
Contributor

jolivares commented Mar 7, 2014

I've tried to address all of your concerns. Let me know if there's any missing issue.

FichteFoll merged commit 50891df into wbond:master Mar 8, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment