Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Typewriter, multiple builds #2927

Merged
merged 1 commit into from Mar 9, 2014

Conversation

Projects
None yet
2 participants
Contributor

alehandrof commented Mar 9, 2014

I want to separate this plugin into two builds, one for ST2 and one for ST3. I am not planning to continue development of the ST2 build; it will be moved to its own branch (st2). I've been using the tags versioning method, which I would like to retain for ST 3 branch, which I will relocate to master (it's in the devel branch currently).

Give the above, does this PR make sense?

Collaborator

FichteFoll commented Mar 9, 2014

Well, kind of. It will be like this:

  • New tags pushed will tell PC on ST3 there is a new version, ST2 will be unaffected.
  • New commits to the ST2 branch will also tell PC there is a "new" version but it will be lower than before (due to internal reasons) and thus not updated. New installations, however, will get the new version then.
    Scratch that. Your highest version is lower than 0.year.month and thus PC will trigger an update once you switch to commit-based versions.

In case you really must update the ST2 package you can always resort back to hosting your own packages.json file and setting an explicit release using the version and release keys for the st2 release.

Collaborator

FichteFoll commented Mar 9, 2014

(I edited my comment, please don't reply via email since I saw you doing that before.)

Contributor

alehandrof commented Mar 9, 2014

First of all thanks for taking the time to walk me through this, and especially for warning me to check the site. On this particular occasion it wasn't needed, but I genuinely appreciate the thought.

Now, as to the PR, I may still be confused. According to your reply:

  • The ST3 build will be fine in the master branch and will update via tags.
  • The ST2 will be fine in the st2 branch for existing users and will update if I push a commit (because I never reached semver 1.0.0).

If the above are correct and you don't have any concerns of your own, go ahead and merge.

Collaborator

FichteFoll commented Mar 9, 2014

Yes, the above is correct, except that ST3 is not limited to any branch because you can create and push tags from any commit.

@FichteFoll FichteFoll added a commit that referenced this pull request Mar 9, 2014

@FichteFoll FichteFoll Merge pull request #2927 from alehandrof/master
Typewriter, multiple builds
dec1384

@FichteFoll FichteFoll merged commit dec1384 into wbond:master Mar 9, 2014

1 check passed

default The Travis CI build passed
Details

@FichteFoll FichteFoll added a commit that referenced this pull request Mar 10, 2014

@FichteFoll FichteFoll Fix erroneous details url from #2927
How ironic that I merged the tests to test exactly this right afterwards ...
ed1ea35
Contributor

alehandrof commented Mar 10, 2014

Thanks and sorry for the messed up URL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment